[Xen-changelog] [xen master] x86/IO-APIC: fix setting of destinations

[patchbot@xxxxxxx]

commit 65288cf610ccf1aae423f65ac67ee5dbeff252a1
Author:     Jan Beulich <jbeulich@xxxxxxxx>
AuthorDate: Thu Nov 19 16:46:10 2015 +0100
Commit:     Jan Beulich <jbeulich@xxxxxxxx>
CommitDate: Thu Nov 19 16:46:10 2015 +0100

    x86/IO-APIC: fix setting of destinations
    
    In commit a85da715cf ("x86/IO-APIC: adjust setting of destinations") I
    made a pretty blatant mistake: get_apic_id() can be used there only
    when running APICs in physical mode. For both flat and clustered modes
    the change was wrong, causing different kinds of boot problems on
    affected systems. Don't revert that change though, but use TARGET_CPUS
    (equaling cpu_online_map, and with there only being a single online CPU
    fulfilling the original commits intention).
    
    Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
    Tested-by: Boris Ostrovsky <boris.ostrovsky@xxxxxxxxxx>
    Reviewed-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
---
 xen/arch/x86/io_apic.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/xen/arch/x86/io_apic.c b/xen/arch/x86/io_apic.c
index 11a0e5d..c2229ad 100644
--- a/xen/arch/x86/io_apic.c
+++ b/xen/arch/x86/io_apic.c
@@ -1039,7 +1039,7 @@ static void __init setup_IO_APIC_irqs(void)
                 disable_8259A_irq(irq_to_desc(irq));
 
             desc = irq_to_desc(irq);
-            SET_DEST(entry, logical, get_apic_id());
+            SET_DEST(entry, logical, cpu_mask_to_apicid(TARGET_CPUS));
             spin_lock_irqsave(&ioapic_lock, flags);
             __ioapic_write_entry(apic, pin, 0, entry);
             set_native_irq_info(irq, TARGET_CPUS);
--
generated by git-patchbot for /home/xen/git/xen.git#master

_______________________________________________
Xen-changelog mailing list
Xen-changelog@xxxxxxxxxxxxx
http://lists.xensource.com/xen-changelog