[Xen-changelog] [xen master] tools: pygrub: if partition table is empty, try treating as a whole disk

[patchbot@xxxxxxx]

commit fb31b1475f1bf179f033b8de3f0e173006fd77e9
Author:     Ian Campbell <ian.campbell@xxxxxxxxxx>
AuthorDate: Thu Nov 5 14:46:12 2015 +0000
Commit:     Ian Campbell <ian.campbell@xxxxxxxxxx>
CommitDate: Mon Nov 16 11:01:50 2015 +0000

    tools: pygrub: if partition table is empty, try treating as a whole disk
    
    pygrub (in identify_disk_image()) detects a DOS style partition table
    via the presence of the 0xaa55 signature at the end of the first
    sector of the disk.
    
    However this signature is also present in whole-disk configurations
    when there is an MBR on the disk. Many filesystems (e.g. ext[234])
    include leading padding in their on disk format specifically to enable
    this.
    
    So if we think we have a DOS partition table but do not find any
    actual partition table entries we may as well try looking at it as a
    whole disk image. Worst case is we probe and find there isn't anything
    there.
    
    This was reported by Sjors Gielen in Debian bug #745419. The fix was
    inspired by a patch by Adi Kriegisch in
    https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=745419#27
    
    Tested by genext2fs'ing my /boot into a new raw image (works) and
    then:
       dd if=/usr/lib/grub/i386-pc/g2ldr.mbr of=img conv=notrunc bs=512 count=1
    
    to add an MBR (with 0xaa55 signature) to it, which after this patch
    also works.
    
    Signed-off-by: Ian Campbell <ian.campbell@xxxxxxxxxx>
    Acked-by: Wei Liu <wei.liu2@xxxxxxxxxx>
    Acked-by: Ian Jackson <ian.jackson@xxxxxxxxxxxxx>
    Cc: 745419-forwarded@xxxxxxxxxxxxxxx
---
 tools/pygrub/src/pygrub |    5 +++++
 1 files changed, 5 insertions(+), 0 deletions(-)

diff --git a/tools/pygrub/src/pygrub b/tools/pygrub/src/pygrub
index e4aedda..40f9584 100755
--- a/tools/pygrub/src/pygrub
+++ b/tools/pygrub/src/pygrub
@@ -156,6 +156,11 @@ def get_partition_offsets(file):
         else:
             part_offs.append(offset)
 
+    # We thought we had a DOS partition table, but didn't find any
+    # actual valid partition entries. This can happen because an MBR
+    # (e.g. grubs) may contain the same signature.
+    if not part_offs: part_offs = [0]
+
     return part_offs
 
 class GrubLineEditor(curses.textpad.Textbox):
--
generated by git-patchbot for /home/xen/git/xen.git#master

_______________________________________________
Xen-changelog mailing list
Xen-changelog@xxxxxxxxxxxxx
http://lists.xensource.com/xen-changelog