[Xen-changelog] [qemu-upstream-unstable] virtio-rng: fix check for period_ms validity

[patchbot@xxxxxxx]

commit b05befcbea71a979509ce04f02929969a790c923
Author:     Amit Shah <amit.shah@xxxxxxxxxx>
AuthorDate: Thu Dec 11 13:17:42 2014 +0530
Commit:     Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>
CommitDate: Fri Aug 21 22:19:34 2015 +0000

    virtio-rng: fix check for period_ms validity
    
    This was reported for this warning:
    
    hw/virtio/virtio-rng.c:150:31: warning: logical not is only applied to
    the left hand side of comparison [-Wlogical-not-parentheses]
    
    upstream-commit-id: a3a292c420d2fec3c07a7ca56fbb064cd57a298a
    Reported-by: dcb
    Suggested-by: dcb
    Bug: https://bugs.launchpad.net/qemu/+bug/1393486
    Reviewed-by: Gonglei <arei.gonglei@xxxxxxxxxx>
    Reviewed-by: Amos Kong <akong@xxxxxxxxxx>
    Signed-off-by: Amit Shah <amit.shah@xxxxxxxxxx>
    Signed-off-by: Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>
---
 hw/virtio/virtio-rng.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/hw/virtio/virtio-rng.c b/hw/virtio/virtio-rng.c
index 473c044..06e7178 100644
--- a/hw/virtio/virtio-rng.c
+++ b/hw/virtio/virtio-rng.c
@@ -149,7 +149,7 @@ static void virtio_rng_device_realize(DeviceState *dev, 
Error **errp)
     VirtIORNG *vrng = VIRTIO_RNG(dev);
     Error *local_err = NULL;
 
-    if (!vrng->conf.period_ms > 0) {
+    if (vrng->conf.period_ms <= 0) {
         error_setg(errp, "'period' parameter expects a positive integer");
         return;
     }
--
generated by git-patchbot for /home/xen/git/qemu-upstream-unstable.git

_______________________________________________
Xen-changelog mailing list
Xen-changelog@xxxxxxxxxxxxx
http://lists.xensource.com/xen-changelog