[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [Xen-changelog] [xen stable-4.5] tools/hotplug: systemd: Don't ever kill xenstored
commit a984d860ee0612f30c1aebbdb94dba801eb7a6e6 Author: Ross Lagerwall <ross.lagerwall@xxxxxxxxxx> AuthorDate: Tue Feb 24 08:05:50 2015 +0000 Commit: Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx> CommitDate: Wed May 27 17:04:23 2015 +0100 tools/hotplug: systemd: Don't ever kill xenstored Don't kill xenstored as part of the usual service shutdown process to prevent hangs on shutdown where the kernel tries to unplug a VIF after xenstored has exited. In an ideal case with all guests cooperating, xendomains will have shut down all guests before xenstored is killed. However in the uncooperative case, malicious or crashed guests may still be running after xendomains has exited and this should not block the shutdown/reboot of dom0. Xenstored has no state to sync to disk, and never used to be killed in the sysvinit case; observe the warning in xencommons. Our testing has shown regressions caused by the change in behaviour between sysvinit and systemd when it comes to killing xenstored. Signed-off-by: Ross Lagerwall <ross.lagerwall@xxxxxxxxxx> Acked-by: Wei Liu <wei.liu2@xxxxxxxxxx> [ ijc -- added systemd to title ] (cherry picked from commit 96e0ee8386cf690c28c46a2c9f75cd2b03f646e1) --- tools/hotplug/Linux/systemd/xenstored.service.in | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/tools/hotplug/Linux/systemd/xenstored.service.in b/tools/hotplug/Linux/systemd/xenstored.service.in index 0f0ac58..a5f836b 100644 --- a/tools/hotplug/Linux/systemd/xenstored.service.in +++ b/tools/hotplug/Linux/systemd/xenstored.service.in @@ -8,6 +8,7 @@ ConditionPathExists=/proc/xen/capabilities [Service] Type=notify +KillMode=none Environment=XENSTORED_ARGS= Environment=XENSTORED=@XENSTORED@ EnvironmentFile=-@CONFIG_DIR@/@CONFIG_LEAF_DIR@/xencommons -- generated by git-patchbot for /home/xen/git/xen.git#stable-4.5 _______________________________________________ Xen-changelog mailing list Xen-changelog@xxxxxxxxxxxxx http://lists.xensource.com/xen-changelog
|
Lists.xenproject.org is hosted with RackSpace, monitoring our |