[Xen-changelog] [xen master] libxl: Don't dereference null new_name pointer in libxl_domain_rename()

[patchbot@xxxxxxx]

commit 276ba7806259c10b186c9cd9115078fb35b28bc7
Author:     Euan Harris <euan.harris@xxxxxxxxxx>
AuthorDate: Mon Dec 1 14:27:06 2014 +0000
Commit:     Ian Campbell <ian.campbell@xxxxxxxxxx>
CommitDate: Tue Dec 2 14:18:57 2014 +0000

    libxl: Don't dereference null new_name pointer in libxl_domain_rename()
    
    libxl__domain_rename() unconditionally dereferences its new_name
    parameter, to check whether it is an empty string.   Add a check to
    avoid a segfault if new_name is null.
    
    Signed-off-by: Euan Harris <euan.harris@xxxxxxxxxx>
    Acked-by: Ian Campbell <ian.campbell@xxxxxxxxxx>
---
 tools/libxl/libxl.c |    7 +++++++
 1 files changed, 7 insertions(+), 0 deletions(-)

diff --git a/tools/libxl/libxl.c b/tools/libxl/libxl.c
index c50c323..74c00dc 100644
--- a/tools/libxl/libxl.c
+++ b/tools/libxl/libxl.c
@@ -385,6 +385,13 @@ int libxl__domain_rename(libxl__gc *gc, uint32_t domid,
         }
     }
 
+    if (!new_name) {
+        LIBXL__LOG(ctx, LIBXL__LOG_ERROR,
+                        "new domain name not specified");
+        rc = ERROR_INVAL;
+        goto x_rc;
+    }
+
     if (new_name[0]) {
         /* nonempty names must be unique */
         uint32_t domid_e;
--
generated by git-patchbot for /home/xen/git/xen.git#master

_______________________________________________
Xen-changelog mailing list
Xen-changelog@xxxxxxxxxxxxx
http://lists.xensource.com/xen-changelog