[Xen-changelog] [xen master] xen/arm32: __cmpxchg_mb should be marked always_inline

[patchbot@xxxxxxx]

commit d2b4c27c0718f27deba00a16317a8ba04c1a2cb7
Author:     Julien Grall <julien.grall@xxxxxxxxxx>
AuthorDate: Thu Apr 3 18:09:10 2014 +0100
Commit:     Ian Campbell <ian.campbell@xxxxxxxxxx>
CommitDate: Tue Apr 8 15:52:44 2014 +0100

    xen/arm32: __cmpxchg_mb should be marked always_inline
    
    Currently __cmpxchg_mb is only marked inline. The compiler can decide to not
    inline this function. In this case, the call to __cmpxchg will be inlined
    but not optimised. This will result linking failure because of 
__bad_cmpxchg.
    
    Caught by clang 3.5.
    
    Signed-off-by: Julien Grall <julien.grall@xxxxxxxxxx>
    Acked-by: Ian Campbell <ian.campbell@xxxxxxxxxx>
---
 xen/include/asm-arm/arm32/cmpxchg.h |    5 +++--
 1 files changed, 3 insertions(+), 2 deletions(-)

diff --git a/xen/include/asm-arm/arm32/cmpxchg.h 
b/xen/include/asm-arm/arm32/cmpxchg.h
index 70c6090..3f4e7a1 100644
--- a/xen/include/asm-arm/arm32/cmpxchg.h
+++ b/xen/include/asm-arm/arm32/cmpxchg.h
@@ -112,8 +112,9 @@ static always_inline unsigned long __cmpxchg(
        return oldval;
 }
 
-static inline unsigned long __cmpxchg_mb(volatile void *ptr, unsigned long old,
-                                        unsigned long new, int size)
+static always_inline unsigned long __cmpxchg_mb(volatile void *ptr,
+                                                unsigned long old,
+                                                unsigned long new, int size)
 {
        unsigned long ret;
 
--
generated by git-patchbot for /home/xen/git/xen.git#master

_______________________________________________
Xen-changelog mailing list
Xen-changelog@xxxxxxxxxxxxx
http://lists.xensource.com/xen-changelog