[Xen-changelog] [xen stable-4.2] x86: PHYSDEVOP_{prepare, release}_msix are privileged

[patchbot@xxxxxxx]

commit f6179b2e3638e1ff3b3f087ce34b0afdb05ed432
Author:     Jan Beulich <jbeulich@xxxxxxxx>
AuthorDate: Fri Jan 24 13:46:43 2014 +0100
Commit:     Jan Beulich <jbeulich@xxxxxxxx>
CommitDate: Fri Jan 24 13:46:43 2014 +0100

    x86: PHYSDEVOP_{prepare,release}_msix are privileged
    
    Yet this wasn't being enforced.
    
    This is XSA-87.
    
    Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
    Reviewed-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
    master commit: 9c7e789a1b60b6114e0b1ef16dff95f03f532fb5
    master date: 2014-01-24 13:41:36 +0100
---
 xen/arch/x86/physdev.c |    4 +++-
 1 files changed, 3 insertions(+), 1 deletions(-)

diff --git a/xen/arch/x86/physdev.c b/xen/arch/x86/physdev.c
index 6cfdab3..8246679 100644
--- a/xen/arch/x86/physdev.c
+++ b/xen/arch/x86/physdev.c
@@ -612,7 +612,9 @@ ret_t do_physdev_op(int cmd, XEN_GUEST_HANDLE(void) arg)
     case PHYSDEVOP_release_msix: {
         struct physdev_pci_device dev;
 
-        if ( copy_from_guest(&dev, arg, 1) )
+        if ( !IS_PRIV(v->domain) )
+            ret = -EPERM;
+        else if ( copy_from_guest(&dev, arg, 1) )
             ret = -EFAULT;
         else
             ret = pci_prepare_msix(dev.seg, dev.bus, dev.devfn,
--
generated by git-patchbot for /home/xen/git/xen.git#stable-4.2

_______________________________________________
Xen-changelog mailing list
Xen-changelog@xxxxxxxxxxxxx
http://lists.xensource.com/xen-changelog