[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Xen-changelog] [qemu-upstream-unstable] virtio_pci: fix level interrupts with irqfd



commit 1cd7138d492304a76f3b8ae89fc61e05b18205a7
Author:     Michael S. Tsirkin <mst@xxxxxxxxxx>
AuthorDate: Sun Sep 1 11:03:45 2013 +0300
Commit:     Michael Roth <mdroth@xxxxxxxxxxxxxxxxxx>
CommitDate: Tue Sep 24 22:16:54 2013 -0500

    virtio_pci: fix level interrupts with irqfd
    
    commit 62c96360ae7f2c7a8b029277fbb7cb082fdef7fd
        virtio-pci: fix level interrupts
    only helps systems without irqfd: on systems with irqfd support we
    passed in flag requesting irqfd even when msix is disabled.
    
    As a result, for level interrupts we didn't install an fd handler so
    unmasking an fd had no effect.
    
    Fix this up.
    
    Cc: qemu-stable@xxxxxxxxxx
    Signed-off-by: Michael S. Tsirkin <mst@xxxxxxxxxx>
    (cherry picked from commit 23fe2b3f9e7df8da53ac1bc32c6875254911d7f4)
    
    Signed-off-by: Michael Roth <mdroth@xxxxxxxxxxxxxxxxxx>
---
 hw/virtio/virtio-pci.c |    3 +--
 1 files changed, 1 insertions(+), 2 deletions(-)

diff --git a/hw/virtio/virtio-pci.c b/hw/virtio/virtio-pci.c
index d37037e..41b96ce 100644
--- a/hw/virtio/virtio-pci.c
+++ b/hw/virtio/virtio-pci.c
@@ -799,8 +799,7 @@ static int virtio_pci_set_guest_notifiers(DeviceState *d, 
int nvqs, bool assign)
             break;
         }
 
-        r = virtio_pci_set_guest_notifier(d, n, assign,
-                                          kvm_msi_via_irqfd_enabled());
+        r = virtio_pci_set_guest_notifier(d, n, assign, with_irqfd);
         if (r < 0) {
             goto assign_error;
         }
--
generated by git-patchbot for /home/xen/git/qemu-upstream-unstable.git

_______________________________________________
Xen-changelog mailing list
Xen-changelog@xxxxxxxxxxxxx
http://lists.xensource.com/xen-changelog


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.