[Xen-changelog] [xen master] x86/mm: Fix possible increment of uninitialised variable

[patchbot@xxxxxxx]

commit ac2f555e37f589fde27c68a306aaac14a424040b
Author:     Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
AuthorDate: Mon Sep 9 18:43:40 2013 +0100
Commit:     Tim Deegan <tim@xxxxxxx>
CommitDate: Tue Sep 10 15:46:35 2013 +0100

    x86/mm: Fix possible increment of uninitialised variable
    
    Discovered by Coverity, CID 1056101
    
    When taking the continue branch on the first iteration of the loop,
    gfn would indeed be uninitialised when incremented.  However, as gfn
    is unconditionally constructed from i{1..4} before use in the loop
    body, having it incremented in the loop header is useless.
    
    Therefore, simply remove it.
    
    Signed-off-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
    Reviewed-by: Jan Beulich <jbeulich@xxxxxxxx>
    Acked-by: Tim Deegan <tim@xxxxxxx>
---
 xen/arch/x86/mm/p2m-pt.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/xen/arch/x86/mm/p2m-pt.c b/xen/arch/x86/mm/p2m-pt.c
index 302b621..a1d5650 100644
--- a/xen/arch/x86/mm/p2m-pt.c
+++ b/xen/arch/x86/mm/p2m-pt.c
@@ -691,7 +691,7 @@ static void p2m_change_type_global(struct p2m_domain *p2m,
                 l1mfn = _mfn(l2e_get_pfn(l2e[i2]));
                 l1e = map_domain_page(mfn_x(l1mfn));
 
-                for ( i1 = 0; i1 < L1_PAGETABLE_ENTRIES; i1++, gfn++ )
+                for ( i1 = 0; i1 < L1_PAGETABLE_ENTRIES; i1++ )
                 {
                     flags = l1e_get_flags(l1e[i1]);
                     if ( p2m_flags_to_type(flags) != ot )
--
generated by git-patchbot for /home/xen/git/xen.git#master

_______________________________________________
Xen-changelog mailing list
Xen-changelog@xxxxxxxxxxxxx
http://lists.xensource.com/xen-changelog