[Xen-changelog] [xen master] xen/arm: gic_shutdown_irq must only disable the right IRQ

[patchbot@xxxxxxx]

commit 751554bfc9dc0363fabf882f6e8855022590ec4d
Author:     Julien Grall <julien.grall@xxxxxxxxxx>
AuthorDate: Fri Jun 28 12:25:57 2013 +0100
Commit:     Ian Campbell <ian.campbell@xxxxxxxxxx>
CommitDate: Fri Jun 28 12:35:59 2013 +0100

    xen/arm: gic_shutdown_irq must only disable the right IRQ
    
    When GICD_ICENABLERn is read, all the 1s bit represent enabled IRQs.
    Currently gic_shutdown_irq:
        - read GICD_ICENABLER
        - set the corresping bit to 1
        - write back the new value
    That means, Xen will disable more IRQs than necessary.
    
    Signed-off-by: Julien Grall <julien.grall@xxxxxxxxxx>
    Acked-by: Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>
    Acked-by: Ian Campbell <ian.campbell@xxxxxxxxxx>
---
 xen/arch/arm/gic.c |    4 +---
 1 files changed, 1 insertions(+), 3 deletions(-)

diff --git a/xen/arch/arm/gic.c b/xen/arch/arm/gic.c
index 177560e..cafb681 100644
--- a/xen/arch/arm/gic.c
+++ b/xen/arch/arm/gic.c
@@ -117,12 +117,10 @@ static unsigned int gic_irq_startup(struct irq_desc *desc)
 
 static void gic_irq_shutdown(struct irq_desc *desc)
 {
-    uint32_t enabler;
     int irq = desc->irq;
 
     /* Disable routing */
-    enabler = GICD[GICD_ICENABLER + irq / 32];
-    GICD[GICD_ICENABLER + irq / 32] = enabler | (1u << (irq % 32));
+    GICD[GICD_ICENABLER + irq / 32] = (1u << (irq % 32));
 }
 
 static void gic_irq_enable(struct irq_desc *desc)
--
generated by git-patchbot for /home/xen/git/xen.git#master

_______________________________________________
Xen-changelog mailing list
Xen-changelog@xxxxxxxxxxxxx
http://lists.xensource.com/xen-changelog