[Xen-changelog] [xen-4.2-testing] x86: properly fail mmuext ops when get_page_from_gfn() fails

[Xen patchbot-4.2-testing <patchbot@xxxxxxx>]

# HG changeset patch
# User Jan Beulich <jbeulich@xxxxxxxx>
# Date 1355307511 -3600
# Node ID 2959e32561384f99603ae8a8d873c8c32e58b624
# Parent  506c772aa77a707ba178eb8bda36fbde50d38c51
x86: properly fail mmuext ops when get_page_from_gfn() fails

I noticed this inconsistency while analyzing the code for XSA-32.

Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
Acked-by: Keir Fraser <keir@xxxxxxx>
xen-unstable changeset: 26260:e80bac7c6598
xen-unstable date: Fri Dec  7 12:40:46 UTC 2012
---


diff -r 506c772aa77a -r 2959e3256138 xen/arch/x86/mm.c
--- a/xen/arch/x86/mm.c Wed Dec 12 09:39:55 2012 +0000
+++ b/xen/arch/x86/mm.c Wed Dec 12 11:18:31 2012 +0100
@@ -3070,7 +3070,7 @@ long do_mmuext_op(
             page = get_page_from_gfn(pg_owner, op.arg1.mfn, NULL, P2M_ALLOC);
             if ( unlikely(!page) )
             {
-                rc = -EINVAL;
+                okay = 0;
                 break;
             }
 
@@ -3130,6 +3130,7 @@ long do_mmuext_op(
             page = get_page_from_gfn(pg_owner, op.arg1.mfn, NULL, P2M_ALLOC);
             if ( unlikely(!page) )
             {
+                okay = 0;
                 MEM_LOG("Mfn %lx bad domain", op.arg1.mfn);
                 break;
             }

_______________________________________________
Xen-changelog mailing list
Xen-changelog@xxxxxxxxxxxxx
http://lists.xensource.com/xen-changelog