[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Xen-changelog] [xen-unstable] Revert 25960:6bf8b882df8f (x86: default-disable MWAIT-based idle driver ...)


  • To: xen-changelog@xxxxxxxxxxxxxxxxxxx
  • From: Xen patchbot-unstable <patchbot@xxxxxxx>
  • Date: Fri, 28 Sep 2012 15:11:10 +0000
  • Delivery-date: Fri, 28 Sep 2012 15:11:18 +0000
  • List-id: "Change log for Mercurial \(receive only\)" <xen-changelog.lists.xen.org>

# HG changeset patch
# User Jan Beulich <jbeulich@xxxxxxxx>
# Date 1348817792 -7200
# Node ID ae1d62ad0333557721088fab73124966b067b46f
# Parent  4496d56c68a0e57ed9f03b482028093f1e7fdf6c
Revert 25960:6bf8b882df8f (x86: default-disable MWAIT-based idle driver ...)

The problem this was working around should be resolved with c/s
25961:6a5812129094 (x86/HPET: don't disable interrupt delivery right
after setting it up).
---


diff -r 4496d56c68a0 -r ae1d62ad0333 xen/arch/x86/cpu/mwait-idle.c
--- a/xen/arch/x86/cpu/mwait-idle.c     Fri Sep 28 09:28:11 2012 +0200
+++ b/xen/arch/x86/cpu/mwait-idle.c     Fri Sep 28 09:36:32 2012 +0200
@@ -71,7 +71,7 @@
 # define pr_debug(fmt...)
 #endif
 
-static __initdata s8 no_mwait_idle = -1;
+static __initdata bool_t no_mwait_idle;
 invbool_param("mwait-idle", no_mwait_idle);
 
 static unsigned int mwait_substates;
@@ -500,13 +500,6 @@ int __init mwait_idle_init(struct notifi
        if (pm_idle_save)
                return -ENODEV;
 
-       /* XXX The no-ARAT case is supposedly being taken care of, but at
-        * least some systems without ARAT hang for some reason, apparently
-        * only when using HPET broadcast mode (PIT broadcast mode seems to
-        * be fine). */
-       if (no_mwait_idle < 0 && boot_cpu_has(X86_FEATURE_ARAT))
-               no_mwait_idle = 0;
-
        err = mwait_idle_probe();
        if (!err) {
                if (!boot_cpu_has(X86_FEATURE_ARAT))

_______________________________________________
Xen-changelog mailing list
Xen-changelog@xxxxxxxxxxxxx
http://lists.xensource.com/xen-changelog


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.