[Xen-changelog] [xen-4.1-testing] xen: fix page_list_splice()

[Xen patchbot-4.1-testing <patchbot@xxxxxxx>]

# HG changeset patch
# User Jan Beulich <jbeulich@xxxxxxxx>
# Date 1346762772 -7200
# Node ID f4cadbe5ce4bc3e05138c541e17f9601bfc35f1b
# Parent  3fe75068fa354d347029d20210d49c765babedac
xen: fix page_list_splice()

Other than in __list_splice(), the first element's prev pointer
doesn't need adjustment here - it already is PAGE_LIST_NULL. Rather
than fixing the assignment (to formally match __list_splice()), simply
assert that this assignment is really unnecessary.

Reported-by: Jisoo Yang <jisooy@xxxxxxxxx>
Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>

Also assert that the prev pointers are both PAGE_LIST_NULL.

Signed-off-by: Keir Fraser <keir@xxxxxxx>
xen-unstable changeset: 25459:f6bfaf9daa50
xen-unstable date: Wed Jun  6 15:37:05 UTC 2012
---


diff -r 3fe75068fa35 -r f4cadbe5ce4b xen/include/xen/mm.h
--- a/xen/include/xen/mm.h      Tue Sep 04 14:45:42 2012 +0200
+++ b/xen/include/xen/mm.h      Tue Sep 04 14:46:12 2012 +0200
@@ -268,7 +268,8 @@ page_list_splice(struct page_list_head *
     last = list->tail;
     at = head->next;
 
-    first->list.prev = page_to_pdx(head->next);
+    ASSERT(first->list.prev == PAGE_LIST_NULL);
+    ASSERT(first->list.prev == at->list.prev);
     head->next = first;
 
     last->list.next = page_to_pdx(at);

_______________________________________________
Xen-changelog mailing list
Xen-changelog@xxxxxxxxxxxxx
http://lists.xensource.com/xen-changelog