[Xen-changelog] [xen-4.1-testing] xen/xsm: fix incorrect handling of XSM hook return

[Xen patchbot-4.1-testing <patchbot@xxxxxxx>]

# HG changeset patch
# User Daniel De Graaf <dgdegra@xxxxxxxxxxxxx>
# Date 1329993050 0
# Node ID 3b9b0d4003a3fa670e64e15a7af5a5c107bc0a37
# Parent  f2543f449a49b8979becbf6888e009973427089a
xen/xsm: fix incorrect handling of XSM hook return

If the XSM hook denied access, the execution incorrectly continued on
after an extra unlock domain.

Reported-by: John McDermott <john.mcdermott@xxxxxxxxxxxx>
Signed-off-by: Daniel De Graaf <dgdegra@xxxxxxxxxxxxx>
Committed-by: Keir Fraser <keir@xxxxxxx>
xen-unstable changeset:   24684:833d80d3fbe7
xen-unstable date:        Thu Feb 02 15:23:04 2012 +0000
---


diff -r f2543f449a49 -r 3b9b0d4003a3 xen/arch/x86/domctl.c
--- a/xen/arch/x86/domctl.c     Mon Feb 13 17:57:47 2012 +0000
+++ b/xen/arch/x86/domctl.c     Thu Feb 23 10:30:50 2012 +0000
@@ -646,7 +646,7 @@
 
         ret = xsm_machine_address_size(d, domctl->cmd);
         if ( ret )
-            rcu_unlock_domain(d);
+            goto set_machine_address_size_out;
 
         ret = -EBUSY;
         if ( d->tot_pages > 0 )

_______________________________________________
Xen-changelog mailing list
Xen-changelog@xxxxxxxxxxxxx
http://lists.xensource.com/xen-changelog