[Xen-changelog] [xen-unstable] xen/xsm: fix incorrect handling of XSM hook return

[Xen patchbot-unstable <patchbot@xxxxxxx>]

# HG changeset patch
# User Daniel De Graaf <dgdegra@xxxxxxxxxxxxx>
# Date 1328196184 0
# Node ID 833d80d3fbe76775bd91c157bb901e35d474a45b
# Parent  1a748779e068368bcf4e57937798c05f6f8ce3ba
xen/xsm: fix incorrect handling of XSM hook return

If the XSM hook denied access, the execution incorrectly continued on
after an extra unlock domain.

Reported-by: John McDermott <john.mcdermott@xxxxxxxxxxxx>
Signed-off-by: Daniel De Graaf <dgdegra@xxxxxxxxxxxxx>
Committed-by: Keir Fraser <keir@xxxxxxx>
---


diff -r 1a748779e068 -r 833d80d3fbe7 xen/arch/x86/domctl.c
--- a/xen/arch/x86/domctl.c     Thu Feb 02 15:21:42 2012 +0000
+++ b/xen/arch/x86/domctl.c     Thu Feb 02 15:23:04 2012 +0000
@@ -648,7 +648,7 @@
 
         ret = xsm_machine_address_size(d, domctl->cmd);
         if ( ret )
-            rcu_unlock_domain(d);
+            goto set_machine_address_size_out;
 
         ret = -EBUSY;
         if ( d->tot_pages > 0 )

_______________________________________________
Xen-changelog mailing list
Xen-changelog@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-changelog