[Xen-changelog] [xen-unstable] libxl: vncviewer: fix use-after-free

[Xen patchbot-unstable <patchbot@xxxxxxx>]

# HG changeset patch
# User Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>
# Date 1296845182 0
# Node ID 3cd9f9db5c21df2cb168381a16736ae90bebe7ab
# Parent  f4d29a2c45ca96c10d86b5fbf537ffcfc62812da
libxl: vncviewer: fix use-after-free

This bug can prevent xl vncviewer from working at all.

Signed-off-by: Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>
Acked-by: Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>
Committed-by: Ian Jackson <ian.jackson@xxxxxxxxxxxxx>
---
 tools/libxl/libxl.c |    3 +--
 1 files changed, 1 insertion(+), 2 deletions(-)

diff -r f4d29a2c45ca -r 3cd9f9db5c21 tools/libxl/libxl.c
--- a/tools/libxl/libxl.c       Fri Feb 04 18:46:00 2011 +0000
+++ b/tools/libxl/libxl.c       Fri Feb 04 18:46:22 2011 +0000
@@ -848,9 +848,8 @@ int libxl_vncviewer_exec(libxl_ctx *ctx,
     }
 
 skip_autopass:
-    libxl__free_all(&gc);
     libxl__exec(autopass_fd, -1, -1, args[0], args);
-    return 0;
+    abort();
 }
 
 
/******************************************************************************/

_______________________________________________
Xen-changelog mailing list
Xen-changelog@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-changelog