[Xen-changelog] [linux-2.6.18-xen] linux: re-order fbfront initialization

["Xen patchbot-linux-2.6.18-xen" <patchbot-linux-2.6.18-xen@xxxxxxxxxxxxxxxxxxx>]

# HG changeset patch
# User Keir Fraser <keir.fraser@xxxxxxxxxx>
# Date 1227100508 0
# Node ID f29bf0bf3e97e882dc3ea6cf83efdee3bd1c1c31
# Parent  69fc220cd737b67e7bd3eca3ab5b84ae7dcbdcdd
linux: re-order fbfront initialization

The helper thread shouldn't be started before xenfb_connect_backend(),
to avoid the thread using the potentially not yet initialized irq.

Signed-off-by: Jan Beulich <jbeulich@xxxxxxxxxx>
---
 drivers/xen/fbfront/xenfb.c |    8 ++++----
 1 files changed, 4 insertions(+), 4 deletions(-)

diff -r 69fc220cd737 -r f29bf0bf3e97 drivers/xen/fbfront/xenfb.c
--- a/drivers/xen/fbfront/xenfb.c       Wed Nov 19 13:14:11 2008 +0000
+++ b/drivers/xen/fbfront/xenfb.c       Wed Nov 19 13:15:08 2008 +0000
@@ -662,6 +662,10 @@ static int __devinit xenfb_probe(struct 
        }
        info->fb_info = fb_info;
 
+       ret = xenfb_connect_backend(dev, info);
+       if (ret < 0)
+               goto error;
+
        /* FIXME should this be delayed until backend XenbusStateConnected? */
        info->kthread = kthread_run(xenfb_thread, info, "xenfb thread");
        if (IS_ERR(info->kthread)) {
@@ -670,10 +674,6 @@ static int __devinit xenfb_probe(struct 
                xenbus_dev_fatal(dev, ret, "register_framebuffer");
                goto error;
        }
-
-       ret = xenfb_connect_backend(dev, info);
-       if (ret < 0)
-               goto error;
 
        return 0;
 

_______________________________________________
Xen-changelog mailing list
Xen-changelog@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-changelog