[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Xen-changelog] [xen-unstable] qemu: Allow more IDE power management.



# HG changeset patch
# User kfraser@xxxxxxxxxxxxxxxxxxxxx
# Date 1188488517 -3600
# Node ID d032a17aced2c240b384cedf3c3ddda37d604bbe
# Parent  b3689eb59c5e7dcdc4c9335c44e621ef405fc1e4
qemu: Allow more IDE power management.

Made the QEMU IDE disk tolerate more power-mgmt commands, specifically:
        WIN_SETFEATURE(EN_AAM)  - enable automatic acoustic mgmt
        WIN_SETFEATURE(DIS_AAM) - disable automatic acoustic mgmt
        WIN_SETFEATURE(DIS_APM) - disable automatic power mgmt
        WIN_STANDBY
        WIN_SETIDLE1
        WIN_SLEEPNOW1
        WIN_STANDBY2
        WIN_SETIDLE2
        WIN_SLEEPNOW2
        WIN_STANDBYNOW2
These are all essentially no-ops, like existing support for EN_RLA
(enable read lookahead) and WIN_STANDBYNOW1.

This fixes a crash in the SLES9-SP3 64bit kernel when the powersaved
was started (with ACPI or ACM).  This guest really only needs EN_AAM,
DIS_APM, and WIN_SETIDLE1 support, but the others seemed sensible to
include.

I've excluded EN_APM since I'm unsure of what that's agreeing to do.
It's probably ok to include.

Signed-off-by: Ben Guthro <bguthro@xxxxxxxxxxxxxxx>
Signed-off-by: David Lively <dlively@xxxxxxxxxxxxxxx>
---
 tools/ioemu/hw/ide.c |   12 +++++++++++-
 1 files changed, 11 insertions(+), 1 deletion(-)

diff -r b3689eb59c5e -r d032a17aced2 tools/ioemu/hw/ide.c
--- a/tools/ioemu/hw/ide.c      Thu Aug 30 16:29:10 2007 +0100
+++ b/tools/ioemu/hw/ide.c      Thu Aug 30 16:41:57 2007 +0100
@@ -1876,6 +1876,9 @@ static void ide_ioport_write(void *opaqu
                 break;
             case 0xaa: /* read look-ahead enable */
             case 0x55: /* read look-ahead disable */
+            case 0x42: /* EN_AAM: enable Automatic Acoustic Mode */
+            case 0xc2: /* DIS_AAM: disable Automatic Acoustic Mode */
+            case 0x85: /* DIS_APM: disable APM */
                 s->status = READY_STAT | SEEK_STAT;
                 ide_set_irq(s);
                 break;
@@ -1914,8 +1917,15 @@ static void ide_ioport_write(void *opaqu
            s->status = READY_STAT;
             ide_set_irq(s);
             break;
-       case WIN_STANDBYNOW1:
         case WIN_IDLEIMMEDIATE:
+        case WIN_STANDBY:
+        case WIN_SETIDLE1:
+        case WIN_STANDBYNOW1:
+        case WIN_SLEEPNOW1:
+        case WIN_STANDBY2:
+        case WIN_SETIDLE2:
+        case WIN_STANDBYNOW2:
+        case WIN_SLEEPNOW2:
            s->status = READY_STAT;
             ide_set_irq(s);
             break;

_______________________________________________
Xen-changelog mailing list
Xen-changelog@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-changelog


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.