| 
    
 [Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [Xen-changelog] fix buffer overflow in print XS_DEBUG command
 # HG changeset patch
# User vhanquez@xxxxxxxxxxxxxxxxxxxxxxx
# Node ID 250ff103c291efeccc4b0ccbf36d228d09712e43
# Parent  51b0d4c2d4d9e2a4ad02c0e3b32fb56f6a8b8126
fix buffer overflow in print XS_DEBUG command
Signed-off-by: Vincent Hanquez <vincent@xxxxxxxxxxxxx>
diff -r 51b0d4c2d4d9 -r 250ff103c291 tools/xenstore/xenstored_core.c
--- a/tools/xenstore/xenstored_core.c   Wed Mar 15 12:08:10 2006
+++ b/tools/xenstore/xenstored_core.c   Wed Mar 15 12:24:34 2006
@@ -1115,8 +1115,17 @@
 
 static void do_debug(struct connection *conn, struct buffered_data *in)
 {
-       if (streq(in->buffer, "print"))
+       int num;
+
+       num = xs_count_strings(in->buffer, in->used);
+
+       if (streq(in->buffer, "print")) {
+               if (num < 2) {
+                       send_error(conn, EINVAL);
+                       return;
+               }
                xprintf("debug: %s", in->buffer + get_string(in, 0));
+       }
        if (streq(in->buffer, "check"))
                check_store();
 #ifdef TESTING
_______________________________________________
Xen-changelog mailing list
Xen-changelog@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-changelog
  | 
  
![]()  | 
            
         Lists.xenproject.org is hosted with RackSpace, monitoring our  |