[Xen-API] add_to_VCPUs_params_live regression in xend 4.1+ XenAPI

[Emile `iMil' Heitor <imil@xxxxxxxxxx>]

Hi,

It seems a regression has been introduced in xen'd XenAPI a while ago:

http://xenbits.xen.org/gitweb/?p=xen.git;a=commitdiff;h=832656a1796170a11fc72035cae542a383a8843c

When calling VM.add_to_VCPUs_params_live(), beginning with version 4.1,
you'll receive the following message:

Failure: Internal error: (22, 'Invalid argument').

And watching xend's log you could witness:

Traceback (most recent call last):
  File "/usr/pkg/lib/python2.7/site-packages/xen/xend/XendAPI.py", line 1656, 
in _VM_VCPUs_params_refresh
    cpus = map(int, value)
  File "/usr/pkg/lib/python2.7/site-packages/xen/xend/XendDomain.py", line 
1609, in domain_pincpu
    cpumap = map(int, cpumap.split(","))
AttributeError: 'list' object has no attribute 'split'
[2013-05-26 09:40:07 407] ERROR (XendDomain:1832) (22, 'Invalid argument')

While reading current version of XendAPI.py, we still can see
cpus = map(int, value.split(",")) which will fail as `value' is already
a list.

Reverting to xendom.domain_pincpu(xeninfo.getDomid(), vcpu, value) makes
VM.add_to_VCPUs_params_live() work again, tested on 4.1.

I know xend is marked as `deprecated', but the fact is there's no successor
when it comes to XenAPI on various systems at the moment. Can this be
reverted and maybe pulled-up?

Thanks,

------------------------------------------------------------------
Emile `iMil' Heitor .°. <imil@{home.imil.net,NetBSD.org,gcu.info}>
                                                                _
              | http://imil.net        | ASCII ribbon campaign ( )
              | http://www.NetBSD.org  |  - against HTML email  X
              | http://gcu.info        |              & vCards / \


_______________________________________________
Xen-api mailing list
Xen-api@xxxxxxxxxxxxx
http://lists.xen.org/cgi-bin/mailman/listinfo/xen-api