Re: [Xen-API] [Xen-devel] [PATCH 4 of 5 v3] tools/ocaml: libxc bindings: Fix stub_xc_readconsolering()

[Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>]

Dave Scott writes ("RE: [Xen-devel] [PATCH 4 of 5 v3] tools/ocaml: libxc 
bindings: Fix stub_xc_readconsolering()"):
> This looks fine to me. I assume the console ring is a C string which
> doesn't contain NULLs in the middle and hence it's sensible to use
> "caml_copy_string" (the alternative would be to treat it as a raw
> block of bytes using "caml_alloc_string" and memcpy-- OCaml strings
> can contain NULLs safely)

The guest is certainly able to write nuls into the console ring if it
wants to.

Ian.

_______________________________________________
Xen-api mailing list
Xen-api@xxxxxxxxxxxxx
http://lists.xen.org/cgi-bin/mailman/listinfo/xen-api