Re: [Xen-API] [xen-api-libs.hg:PATCH 0 of 2] Uuid stuff.

[Jonathan Knowles <jonathan.knowles@xxxxxxxxxxxxx>]

On 29/07/10 16:46, magnus.therning@xxxxxxxxxxxxx wrote:
> This is not ready for merging, but I'd like some comments on the code
> and direction.
>
> Besides the minor clean-up (is more needed?) it introduces a new
> function, make_uuid_random, which reads from /dev/random (and
> therefore may block).
>
> The plan is to change make_uuid to use the PRNG in Random, and then
> modify xapi so that make_uuid_random is used where it's necessary
> (creating pool secret and sessions, what else?).
After applying your patches, UUID has two constructors:

> val make_uuid        : unit -> 'a t
> val make_uuid_random : unit -> 'a  t
If your intent is that:

    * function "make_uuid"        uses a PRNG
    * function "make_uuid_random" uses /dev/random

then why not make the difference more explicit to the caller.
For example:

> val make_uuid_pseudo_random : unit -> 'a t
> val make_uuid_really_random : unit -> 'a t
Otherwise, it's not very clear to users of the API what they'll
get by calling "make_uuid".

Cheers,
Jonathan
--------
Jonathan Knowles

_______________________________________________
xen-api mailing list
xen-api@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/mailman/listinfo/xen-api