RE: [Xen-API] [PATCH] Just sanitizing indentation in stdext/listext.mli

[Jonathan Davies <Jonathan.Davies@xxxxxxxxxxxxx>]

Hi Matthias,

The current version of the guidelines state that tabs are preferred to spaces: 
http://wiki.xensource.com/xenwiki/OCaml_Best_Practices#line-223

However, a lot of the existing source files use spaces. Moreover, some source 
files contain an ugly mix of spaces and tabs. Generally, the informal policy 
for patching an existing file is to try to use tabs where possible unless this 
would make the formatting of the new code inconsistent with nearby code in the 
same file.

Of course, another option would be to reformat entire files so that they are 
consistent with the guidelines, but this would have the unfortunate 
side-effects of (i) obscuring the history of the files (consider the output of 
hg annot) and (ii) causing needless merge headaches for anyone who has an 
existing patch against the original file.

Regards,

Jonathan

On 30 April 2010 12:12, Matthias Goergens wrote:
> Hi Jonathan,
> 
> I am just looking over my recent patches.  There are lots of instances
> where I use spaces instead of tabs.  Unfortunately the surrounding
> source file uses spaces often, too.
> 
> I guess I will just correct the tabs in the patches when either the
> surroundings use tabs already, or when the patch is explicitly aimed at
> fixing indentation.
> 
> What do you think?
> 
> Matthias.
> 
> _______________________________________________
> xen-api mailing list
> xen-api@xxxxxxxxxxxxxxxxxxx
> http://lists.xensource.com/mailman/listinfo/xen-api

_______________________________________________
xen-api mailing list
xen-api@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/mailman/listinfo/xen-api