[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[RFC PATCH 3/7] xeniface: Enforce read-only foreign page views


  • To: win-pv-devel@xxxxxxxxxxxxxxxxxxxx
  • From: Rafał Wojdyła <omeg@xxxxxxxxxxxxxxxxxxxxxx>
  • Date: Tue, 10 Nov 2026 19:34:50 +0100
  • Authentication-results: eu.smtp.expurgate.cloud; dkim=pass header.s=fm3 header.d=invisiblethingslab.com header.i="@invisiblethingslab.com" header.h="Cc:Content-Transfer-Encoding:Content-Type:Date:From:In-Reply-To:Message-ID:MIME-Version:References:Subject:To"; dkim=pass header.s=fm3 header.d=messagingengine.com header.i="@messagingengine.com" header.h="Cc:Content-Transfer-Encoding:Content-Type:Date:Feedback-ID:From:In-Reply-To:Message-ID:MIME-Version:References:Subject:To:X-ME-Proxy:X-ME-Sender"
  • Cc: Rafał Wojdyła <omeg@xxxxxxx>, Rafał Wojdyła <omeg@xxxxxxxxxxxxxxxxxxxxxx>
  • Delivery-date: Tue, 10 Nov 2026 18:36:07 +0000
  • Dkim2-signature: i=1; m=1; t=1794335764; d=invisiblethingslab.com; mf=PG9tZWdAaW52aXNpYmxldGhpbmdzbGFiLmNvbT4=; rt=PHdpbi1wdi1kZXZlbEBsaXN0cy54ZW5wcm9qZWN0Lm9yZz4=; s=fm3:rsa-sha256:Hf2GeYIy0Ag3J7/mu6wXeiQvmfEDjxlQdspTp3bSsYY7zv3 avSv1g5VrABbl7gGl2ELMiGjGxACpho5tRvWCsfMbgOPw/fjYtLZ7ooiwkjARBJk OP453d3VVvvudEH7kJVS1pVtviidkmeR7DF8RFHrVZpFlYl7eVOAAZoOgeHZLcf9 hqYh3yo6SDlHsvdsQ6SyNY9S5NnTsHv9wj/4Eda1OXKZShx0Af7Uw2vv7CsOnazW PEg1Iiw0/Lo41IWXlnGeflAyBNmGOLktZQU85Q2JOywGpPZkfd/ONW6fgJ0In6GX PicChsNWcoEZfnRAKlJaZntDZIlvMg9Nlrc8m0w==;
  • Feedback-id: i409c4082:Fastmail
  • List-id: Developer list for the Windows PV Drivers subproject <win-pv-devel.lists.xenproject.org>
  • Message-instance: m=1; h=sha256:MYzxJA105GZkW/K/XWl3n0OhtYVIbzeExKq4G3VsH40=:NzNLHszClSx8v0seXreV20rPi1D1tE66OLGWsxcqo1Y=;

From: Rafał Wojdyła <omeg@xxxxxxx>

Pass MdlMappingNoWrite when exposing read-only foreign pages to user
mode. Reject notify byte configuration for these mappings because cleanup
must not write through a read-only foreign mapping.

Assisted-by: LLM
Signed-off-by: Rafał Wojdyła <omeg@xxxxxxxxxxxxxxxxxxxxxx>
---
 src/xeniface/ioctl_gnttab.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/src/xeniface/ioctl_gnttab.c b/src/xeniface/ioctl_gnttab.c
index c6d82bc..12b1c0a 100644
--- a/src/xeniface/ioctl_gnttab.c
+++ b/src/xeniface/ioctl_gnttab.c
@@ -717,7 +717,8 @@ IoctlGnttabMapForeignPages(
     }
 
     if ((In->Flags & XENIFACE_GNTTAB_USE_NOTIFY_OFFSET) &&
-        (In->NotifyOffset >= In->NumberPages * PAGE_SIZE)) {
+        (In->NotifyOffset >= In->NumberPages * PAGE_SIZE ||
+         (In->Flags & XENIFACE_GNTTAB_READONLY))) {
         goto fail7;
     }
 
@@ -771,7 +772,8 @@ IoctlGnttabMapForeignPages(
                                                        MmCached,
                                                        NULL,
                                                        FALSE,
-                                                       NormalPagePriority);
+                                                       NormalPagePriority |
+                                                       ((Context->Flags & 
XENIFACE_GNTTAB_READONLY) ? MdlMappingNoWrite : 0));
     } except (EXCEPTION_EXECUTE_HANDLER) {
         status = GetExceptionCode();
         goto fail12;
-- 
2.56.0




 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.