[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[RFC PATCH 1/7] xeniface: Avoid accessing grant IRPs after they are pended


  • To: win-pv-devel@xxxxxxxxxxxxxxxxxxxx
  • From: Rafał Wojdyła <omeg@xxxxxxxxxxxxxxxxxxxxxx>
  • Date: Tue, 10 Nov 2026 19:34:48 +0100
  • Authentication-results: eu.smtp.expurgate.cloud; dkim=pass header.s=fm3 header.d=invisiblethingslab.com header.i="@invisiblethingslab.com" header.h="Cc:Content-Transfer-Encoding:Content-Type:Date:From:In-Reply-To:Message-ID:MIME-Version:References:Subject:To"; dkim=pass header.s=fm3 header.d=messagingengine.com header.i="@messagingengine.com" header.h="Cc:Content-Transfer-Encoding:Content-Type:Date:Feedback-ID:From:In-Reply-To:Message-ID:MIME-Version:References:Subject:To:X-ME-Proxy:X-ME-Sender"
  • Cc: Rafał Wojdyła <omeg@xxxxxxx>, Rafał Wojdyła <omeg@xxxxxxxxxxxxxxxxxxxxxx>
  • Delivery-date: Tue, 10 Nov 2026 18:35:56 +0000
  • Dkim2-signature: i=1; m=1; t=1794335752; d=invisiblethingslab.com; mf=PG9tZWdAaW52aXNpYmxldGhpbmdzbGFiLmNvbT4=; rt=PHdpbi1wdi1kZXZlbEBsaXN0cy54ZW5wcm9qZWN0Lm9yZz4=; s=fm3:rsa-sha256:VZmX3XLYdOETGWJraVWk9S2i4JVuCC87+wPplyIujamIJqO AXki2JvdFKYIhrWHdlmD9rWKFxdxqUAAKeVM3T6N34PFZ9Vd3frGpCd+tOerMRKp MkMjBxvobTg59JQ9VlpR/nASu6p2FsdMi9NjltjN50T/IiJ4SVStn2aodXuIaBCm C6LHFpL6PJH+RCS88UqvO3yZog1dsHdeZxniaCQSbHWTUvRsNHNpljiY+0OGYSN6 b4XxH8yeIJsfRKwzjfhF1vQ/Gr8vgy0KRTvf0Viw1x72JP5hRBDxUgReJpEX7ioU TT1pMdvkCp+rdvvvuL4OhhADDGNKyp3xS4A+GGg==;
  • Feedback-id: i409c4082:Fastmail
  • List-id: Developer list for the Windows PV Drivers subproject <win-pv-devel.lists.xenproject.org>
  • Message-instance: m=1; h=sha256:AUcMLh54pt9s+EQ58qk2M1PruWSxvUHG5c+ij/RbCbc=:OlVamD9pgg38p1GVLEXHhUMJFQucMrrKgJIZ2/EI9m0=;

From: Rafał Wojdyła <omeg@xxxxxxx>

A cancel-safe queue can hand a pending grant request to its cancellation
worker before the IOCTL handler returns. Only set IoStatus and complete the
IRP when the handler did not return STATUS_PENDING, avoiding an access after
another path has completed the request.

Assisted-by: LLM
Signed-off-by: Rafał Wojdyła <omeg@xxxxxxxxxxxxxxxxxxxxxx>
---
 src/xeniface/ioctls.c | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/src/xeniface/ioctls.c b/src/xeniface/ioctls.c
index f9c959e..3d55d5a 100644
--- a/src/xeniface/ioctls.c
+++ b/src/xeniface/ioctls.c
@@ -374,10 +374,11 @@ XenIfaceIoctl(
 
 done:
 
-    Irp->IoStatus.Status = status;
-
-    if (status != STATUS_PENDING)
+    // A pending request can already belong to a cancellation/cleanup worker.
+    if (status != STATUS_PENDING) {
+        Irp->IoStatus.Status = status;
         IoCompleteRequest(Irp, IO_NO_INCREMENT);
+    }
 
     return status;
 }
-- 
2.56.0




 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.