|
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] Re: [PATCH v2 10/10] ring: Defer request completion until backend grant release
>
> +_Check_return_
> +static BOOLEAN
> +BlkifRingTryPutRequest(
> + _Inout_ PXENVBD_BLKIF_RING BlkifRing,
> + _Inout_ PXENVBD_REQUEST Request
> + )
> +{
> + PXENVBD_RING Ring = BlkifRing->Ring;
> + PXENVBD_GRANTER Granter =
> FrontendGetGranter(Ring->Frontend);
> + PXENVBD_SRBEXT SrbExt = Request->SrbExt;
> + PLIST_ENTRY ListEntry;
> +
> + for (ListEntry = Request->Segments.Flink;
> + ListEntry != &Request->Segments;
> + ListEntry = ListEntry->Flink) {
> + PXENVBD_SEGMENT Segment = CONTAINING_RECORD(ListEntry,
> XENVBD_SEGMENT, ListEntry);
> +
> + if (Segment->Grant == NULL)
> + continue;
> +
> + if (!NT_SUCCESS(GranterTryPut(Granter, Segment->Grant)))
> + return FALSE;
> +
Should a GranterTryPut be attempted for all Segment->Grants to attempt to return
grantrefs as early as possible - any failure can be flagged and prevent the
Request being recycled into the CACHE
> + Segment->Grant = NULL;
> + }
> +
> + for (ListEntry = Request->Indirects.Flink;
> + ListEntry != &Request->Indirects;
> + ListEntry = ListEntry->Flink) {
> + PXENVBD_INDIRECT Indirect = CONTAINING_RECORD(ListEntry,
> XENVBD_INDIRECT, ListEntry);
> +
> + if (Indirect->Grant == NULL)
> + continue;
> +
> + if (!NT_SUCCESS(GranterTryPut(Granter, Indirect->Grant)))
> + return FALSE;
> +
Same as above
> + Indirect->Grant = NULL;
> + }
> +
> + for (;;) {
> + PXENVBD_SEGMENT Segment;
> +
> + ListEntry = RemoveHeadList(&Request->Segments);
> + if (ListEntry == &Request->Segments)
> + break;
> + Segment = CONTAINING_RECORD(ListEntry, XENVBD_SEGMENT, ListEntry);
> + BlkifRingPutSegment(BlkifRing, Segment);
> + }
> +
> + for (;;) {
> + PXENVBD_INDIRECT Indirect;
> +
> + ListEntry = RemoveHeadList(&Request->Indirects);
> + if (ListEntry == &Request->Indirects)
> + break;
> + Indirect = CONTAINING_RECORD(ListEntry, XENVBD_INDIRECT, ListEntry);
> + BlkifRingPutIndirect(BlkifRing, Indirect);
> + }
> +
return FALSE at this point when not all grants are revoked
> + Request->SrbExt = NULL;
> + Request->Operation = 0;
> + Request->Flags = 0;
> + Request->NrSegments = 0;
> + Request->FirstSector = 0;
> + Request->NrSectors = 0;
> + RtlZeroMemory(&Request->ListEntry, sizeof(LIST_ENTRY));
> +
> + XENBUS_CACHE(Put,
> + &Ring->CacheInterface,
> + BlkifRing->RequestCache,
> + Request,
> + TRUE);
> +
> + __BlkifRingPutSrb(BlkifRing, SrbExt);
> +
> + return TRUE;
> +}
>
Owen
|
![]() |
Lists.xenproject.org is hosted with RackSpace, monitoring our |