[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2 10/10] ring: Defer request completion until backend grant release


  • To: Tu Dinh <ngoc-tu.dinh@xxxxxxxxxx>, "win-pv-devel@xxxxxxxxxxxxxxxxxxxx" <win-pv-devel@xxxxxxxxxxxxxxxxxxxx>
  • From: Owen Smith <owen.smith@xxxxxxxxxx>
  • Date: Thu, 29 Oct 2026 10:50:29 +0000
  • Accept-language: en-GB, en-US
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=OmoKemZHf3GlM5L7Aa8819193yOhh91Adql/zt5PBBQ=; b=yEzJHjccd3U1vx2wzbvI2uk5B8mzcwD0BfZzdWP3iu+vttN/u+1V1j/i1PQUxw91IlUl/LWYAHKo0F+fU43Xs1xUHqLkevhxs7sV/ypHKaR6eET9z5OFYo0QPrEGq+G25P/eWw0N364uhVWW52fu9pWEqjhE1PTOYPEX8vM5KoF+aypsd1uZS6+Ou3wfW/K62hTuKD0hPrdRB1aiCLRKfaAof7XtABhQN3BweHhOpvgak7bcaBCdyx+OZHbXU6ZkaexBwJ5fc8foFGGLob+eiRgKdJqvYrwqwzyH5ypdal7DgT0F4gl9FT/GkWvTcR3bGzxaXaPV3xT5K7vj1EW+cA==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=t1rjh83vhtJx1LxhejFJID5grjJXkBtT1wfBW24iemiOmC5dieOAH1hHgGbRfm3JgzIYEv8MqwU2kqChggIdrAgXJMU+BIXoCrz6kXgFeu0ZSBZNKxs8gW+tSKyRoGjZZs4pcsct0zCC/+pPn7atp24KzoXowzKAW8WGyZo36qiOL+xLfIMx0Dob3d+6fKotl8P44EBlLNiFY6VxVGnriw5Wl9Z6VIJqKJ+Ax7Bi5Cy+7ZlyfCO9azqbsmIirP++2HcKGGeuyOeEAvrHA4yqkbz/daMSLyMqCT1nwXmZueTZQUNg1aP+SnqudfqZ2yDv5F04NIPZPmmXWdFPqSYTHw==
  • Authentication-results: eu.smtp.expurgate.cloud; dkim=pass header.s=selector1 header.d=citrix.com header.i="@citrix.com" header.h="From:Date:Subject:Message-ID:Content-Type:MIME-Version:x-ms-exchange-senderadcheck"
  • Authentication-results: mx.microsoft.com 1; dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com;
  • Delivery-date: Thu, 29 Oct 2026 10:50:36 +0000
  • List-id: Developer list for the Windows PV Drivers subproject <win-pv-devel.lists.xenproject.org>
  • Msip_labels:
  • Thread-index: AQHdZwBwMC9H7ccDx0mYY8HPu9zqOLcUV8Jn
  • Thread-topic: [PATCH v2 10/10] ring: Defer request completion until backend grant release

>  
>  +_Check_return_
>  +static BOOLEAN
>  +BlkifRingTryPutRequest(
>  +    _Inout_ PXENVBD_BLKIF_RING  BlkifRing,
>  +    _Inout_ PXENVBD_REQUEST     Request
>  +    )
>  +{
>  +    PXENVBD_RING                Ring = BlkifRing->Ring;
>  +    PXENVBD_GRANTER             Granter = 
> FrontendGetGranter(Ring->Frontend);
>  +    PXENVBD_SRBEXT              SrbExt = Request->SrbExt;
>  +    PLIST_ENTRY                 ListEntry;
>  +
>  +    for (ListEntry = Request->Segments.Flink;
>  +         ListEntry != &Request->Segments;
>  +         ListEntry = ListEntry->Flink) {
>  +        PXENVBD_SEGMENT Segment = CONTAINING_RECORD(ListEntry, 
> XENVBD_SEGMENT, ListEntry);
>  +
>  +        if (Segment->Grant == NULL)
>  +            continue;
>  +
>  +        if (!NT_SUCCESS(GranterTryPut(Granter, Segment->Grant)))
>  +            return FALSE;
>  +

Should a GranterTryPut be attempted for all Segment->Grants to attempt to return
grantrefs as early as possible - any failure can be flagged and prevent the
Request being recycled into the CACHE

>  +        Segment->Grant = NULL;
>  +    }
>  +
>  +    for (ListEntry = Request->Indirects.Flink;
>  +         ListEntry != &Request->Indirects;
>  +         ListEntry = ListEntry->Flink) {
>  +        PXENVBD_INDIRECT    Indirect = CONTAINING_RECORD(ListEntry, 
> XENVBD_INDIRECT, ListEntry);
>  +
>  +        if (Indirect->Grant == NULL)
>  +            continue;
>  +
>  +        if (!NT_SUCCESS(GranterTryPut(Granter, Indirect->Grant)))
>  +            return FALSE;
>  +

Same as above

>  +        Indirect->Grant = NULL;
>  +    }
>  +
>  +    for (;;) {
>  +        PXENVBD_SEGMENT Segment;
>  +
>  +        ListEntry = RemoveHeadList(&Request->Segments);
>  +        if (ListEntry == &Request->Segments)
>  +            break;
>  +        Segment = CONTAINING_RECORD(ListEntry, XENVBD_SEGMENT, ListEntry);
>  +        BlkifRingPutSegment(BlkifRing, Segment);
>  +    }
>  +
>  +    for (;;) {
>  +        PXENVBD_INDIRECT    Indirect;
>  +
>  +        ListEntry = RemoveHeadList(&Request->Indirects);
>  +        if (ListEntry == &Request->Indirects)
>  +            break;
>  +        Indirect = CONTAINING_RECORD(ListEntry, XENVBD_INDIRECT, ListEntry);
>  +        BlkifRingPutIndirect(BlkifRing, Indirect);
>  +    }
>  +

return FALSE at this point when not all grants are revoked

>  +    Request->SrbExt = NULL;
>  +    Request->Operation = 0;
>  +    Request->Flags = 0;
>  +    Request->NrSegments = 0;
>  +    Request->FirstSector = 0;
>  +    Request->NrSectors = 0;
>  +    RtlZeroMemory(&Request->ListEntry, sizeof(LIST_ENTRY));
>  +
>  +    XENBUS_CACHE(Put,
>  +                 &Ring->CacheInterface,
>  +                 BlkifRing->RequestCache,
>  +                 Request,
>  +                 TRUE);
>  +
>  +    __BlkifRingPutSrb(BlkifRing, SrbExt);
>  +
>  +    return TRUE;
>  +}
>  

Owen


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.