[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] Add UseConsole parameter to disable default console
- To: Tu Dinh <ngoc-tu.dinh@xxxxxxxxxx>, "win-pv-devel@xxxxxxxxxxxxxxxxxxxx" <win-pv-devel@xxxxxxxxxxxxxxxxxxxx>
- From: Owen Smith <owen.smith@xxxxxxxxxx>
- Date: Mon, 26 Oct 2026 10:42:54 +0000
- Accept-language: en-GB, en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=l8w3E9l+0tRdPPKqal6LzlStfPeczJhCn5hihPEa8Tg=; b=iuLN/Q+I67hF1RVqIVxBjhwpnECpebgO7v/TX7BeP3dGrLn6s9TBjmmF3UykZ/PgFiKVE0Knl/9OvvVhPhvq76/7KmnrunV1mx08vReqk9By8Z7gVlwGt6UcmBnHOi249UWJzk0Vla/qv9oyjrY6r3HKcCaq7+kVW44/TvjIJTM+jbcsKn565aL9hxWsLHK3it55lYrW//0A84DwwFqSyR4J/x6PtfbDBpoAjOnS0Ok+pY2OraGHUY1uN83WePIUvvdDes80F8B/digyMdWTc0RAfFEfDFhU8URC+Xs0FQIFsGbP4OoD7aaZVG+OuFCNMU+rxhsEXxAocNtXJgCFtw==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=Mor8Gq4vEFL9BIZjEX1miz/yWgz4Nev5b1Rlwc7XBGOdB1QXRSrs+Nm3JP447cbKVRDtVgzz3CbkhmlLGVFGp2ESb3KQW1Wcn1u/W+Vobg2TDnbat53oxKUQf92V3gKb/OFR1TAUm2kic9gJ9cbVRFUB3cMoO4RvxxcBYxr49I7oamWXWn9OhT8Nyinw7kkgp4+oEvGpycf7MyzVDh4hfbjg9C33MGhglheo3RDvaIMuGEqM8QBH13vu+TcodRjAh/omVcxXd/FTrk0ODzQFGe77djfr2I9UCnNhPph5yPDaRQSk6lIAlmS3HSRFHoOCtYglGh0EAuOuIxg2hD1aHA==
- Authentication-results: eu.smtp.expurgate.cloud; dkim=pass header.s=selector1 header.d=citrix.com header.i="@citrix.com" header.h="From:Date:Subject:Message-ID:Content-Type:MIME-Version:x-ms-exchange-senderadcheck"
- Authentication-results: mx.microsoft.com 1; dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com;
- Delivery-date: Mon, 26 Oct 2026 10:42:59 +0000
- List-id: Developer list for the Windows PV Drivers subproject <win-pv-devel.lists.xenproject.org>
- Msip_labels:
- Thread-index: AQHdZRdnsgXsHTe+9UuY0/QI3ZURircPmdnogAAEloCAAAE2mg==
- Thread-topic: [PATCH] Add UseConsole parameter to disable default console
> On 26/10/2026 11:15, Owen Smith wrote:
> > By setting "UseConsole" = 1, the default console (and CONSOLE) interface
> > will fail.
> > The default console's PDO will still be created, but any attempt to call
> > CreateFile will
> > fail, so I'd assume any alternate use would need to manage the default
> > console ring
> > itself. Non-default console's PDOs are unaffected.
> >
>
> My idea is to totally prevent xenbus and others from touching the
> default console ring and leave the console ring's usage to some other
> applications. That seemed simpler than swallowing read/write requests at
> first glance.
>
> From my testing, it looks like I can still open handles to the default
> console PDO XENCONS\VEN_XN&DEV_CONSOLE\0 (e.g. Get-NtFile -Access
> ReadData,WriteData,Synchronize -ShareMode Delete \Device\...). Although
> I haven't tested this point further.
>
PdoDispatchCreate calls the console's ABI Open, which does not directly call
the CONSOLE(Acquire) interface, so the PDO can be opened (I missed this)
The default console's StreamWorker thread will attempt to acquire the console
interface and fail, skipping any attempt to drive the default console ring.
StreamPutQueue will allow IRPs to be queued, but nothing will pop them until
they are cancelled.
Owen
|
