[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 0/5] xeniface: fixes from static analysis
- To: Césaire Mounah <cesaire.mounah@xxxxxxxxxx>, "win-pv-devel@xxxxxxxxxxxxxxxxxxxx" <win-pv-devel@xxxxxxxxxxxxxxxxxxxx>
- From: Owen Smith <owen.smith@xxxxxxxxxx>
- Date: Wed, 21 Oct 2026 07:00:53 +0000
- Accept-language: en-GB, en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=GaUdD6XOcNqJp1cXP0a21HmHosFsiH5febToYQtayuo=; b=rkghsVJ9xJWfit0h9E6Roy3lQINLf9scEIeX00rBvS/+aAM7Ld7D6/5OU2f/Sr2D/tK2e60RkACuxOgmtcytke1dXBLWhdP2HA6B5GANfATm1iy8T1iW4qcUKOz8ohQ+GAp2YDHuxXmNDTn5+CnfPYWvsMNECyq/+TlBccySrwlsE3v1Z/Jsfgake/yMmjafGrslD7vJ2qjOLY+ZvJkOj/yNbEvpNn0goqP36/63SfKRbWP+I3omzhJhYFUynfbZMzIguG9CXcs9rng2ebj7kFREBo5NVNDaJe+jcsPLfcBNG9pXQsIKemc+5zC0s4nzGpccdENYY99LswpTgqUh4Q==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=ev2Guw2GIgtkgHz7sSipIeucsQ31P+15LSBtZfrKbEzXkvaIcmvr+LxqToc2EbmW70nYhr5wkTqZho60jJOua8xjaGrdrp7LBxCIEbgYYUTB5K7LmIpLVx0idmUGLMW33bZru84X5JSOs9IXipvJojHRcSf6WH2DZ+YQPx5t6i6amBJsSLVdVY53eY6xXWHfMcRuVQ3BtrfC4hxD1XZXuagdVueYK6CAPLczCR5u2LYI60n38Z2rcL4LqgfHAlQPC4/b1W+qOJXSjfZRjBmF7fk4y90eTV7V/6hJ19k/+393V8eginoWx9YJ+mQQTfqUHHaFhKQ4K23IxIOoXopGVg==
- Authentication-results: eu.smtp.expurgate.cloud; dkim=pass header.s=selector1 header.d=citrix.com header.i="@citrix.com" header.h="From:Date:Subject:Message-ID:Content-Type:MIME-Version:x-ms-exchange-senderadcheck"
- Authentication-results: mx.microsoft.com 1; dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com;
- Delivery-date: Wed, 21 Oct 2026 07:00:59 +0000
- List-id: Developer list for the Windows PV Drivers subproject <win-pv-devel.lists.xenproject.org>
- Msip_labels:
- Thread-index: AQHdYImeehpwnnBaOk2CIKWeI3EbgrcHknXO
- Thread-topic: [PATCH 0/5] xeniface: fixes from static analysis
The first 4 patches look good - a minor issue with the last patch.
I will apply the first 4 patches
First 4 - Reviewed-by: Owen Smith <owen.smith@xxxxxxxxxx>
________________________________________
From: win-pv-devel <win-pv-devel-bounces@xxxxxxxxxxxxxxxxxxxx> on behalf of
Césaire Mounah <cesaire.mounah@xxxxxxxxxx>
Sent: 20 October 2026 12:53 PM
To: win-pv-devel@xxxxxxxxxxxxxxxxxxxx
Cc: Césaire Mounah
Subject: [PATCH 0/5] xeniface: fixes from static analysis
These patches fix issues found by running CodeQL (Microsoft
windows-drivers suites and cpp-security-extended) on xeniface.
Césaire Mounah (5):
xenagent: Use new (std::nothrow) where the result is checked for NULL
xenagent: Let CXenIfaceDevice release its own registrations
xeniface: Reject unaligned addresses in
GNTTAB_PERMIT_FOREIGN_ACCESS_V2
xeniface: Size converted MAP_FOREIGN_PAGES input with the V2 header
xeniface: Bound NumberPermissions before checking the input length
src/xenagent/convdevice.cpp | 3 +-
src/xenagent/devicelist.cpp | 11 +-
src/xenagent/xenifacedevice.cpp | 177 +++++++++++++++++---------------
src/xenagent/xenifacedevice.h | 20 ++--
src/xeniface/ioctl_gnttab.c | 6 +-
src/xeniface/ioctl_store.c | 5 +
6 files changed, 125 insertions(+), 97 deletions(-)
--
2.55.0.windows.5
--
Césaire Mounah | Vates Windows Guest Tools Engineer
XCP-ng & Xen Orchestra - Vates solutions
web: https://vates.tech
|
