Re: [PATCH 00/11] xenvkbd: Update annotations to SAL 2.0

[Owen Smith <owen.smith@xxxxxxxxxx>]

This series looks good.
I did notice no change to the INF, but since there is no interface version 
changes,
INF binding changes are not required. It may become needed later.

Reviewed-by: Owen Smith <owen.smith@xxxxxxxxxx>

________________________________________
From: win-pv-devel <win-pv-devel-bounces@xxxxxxxxxxxxxxxxxxxx> on behalf of 
Césaire Mounah <cesaire.mounah@xxxxxxxxxx>
Sent: 19 October 2026 2:12 PM
To: win-pv-devel@xxxxxxxxxxxxxxxxxxxx
Cc: Césaire Mounah
Subject: [PATCH 00/11] xenvkbd: Update annotations to SAL 2.0

This patch series updates the xenvkbd driver to use SAL 2.0
annotations and fixes the issues found after code analysis.

It is organized into three parts: sync common files with xenbus,
update annotations to SAL 2.0, and fix issues found after code analysis.

Part 1: Sync common files with xenbus
* xenvkbd: sync common files with xenbus
* registry: sync with xenbus
* xenvkbd: sync xenhid interface

Part 2: Update annotations to SAL 2.0
* xenvkbd: convert annotations to SAL 2.0
* xenvkbd: Update string typedefs
* xenvkbd: Annotate remaining unannotated parameters
* xenvkbd: Annotate modified parameters as _Out_ or _Inout_
* xenvkbd: Add size annotations to buffer parameters

Part 3: Fix issues found after code analysis
* xenvkbd: Fix annotations reported by code analysis
* driver: fix inconsistent annotation
* xenvkbd: Add an ASSERT on the array bound in SetArray

Césaire Mounah (11):
  xenvkbd: sync common files with xenbus
  registry: sync with xenbus
  xenvkbd: sync xenhid interface
  xenvkbd: convert annotations to SAL 2.0
  xenvkbd: Update string typedefs
  xenvkbd: Annotate remaining unannotated parameters
  xenvkbd: Annotate modified parameters as _Out_ or _Inout_
  xenvkbd: Add size annotations to buffer parameters
  xenvkbd: Fix annotations reported by code analysis
  driver: fix inconsistent annotation
  xenvkbd: Add an ASSERT on the array bound in SetArray

 include/cache_interface.h     | 130 ++++-----
 include/debug_interface.h     |  88 +++---
 include/evtchn_interface.h    | 136 +++++-----
 include/gnttab_interface.h    | 148 +++++------
 include/hid_interface.h       | 108 ++++----
 include/range_set_interface.h | 100 +++----
 include/store_interface.h     | 156 +++++------
 include/suspend_interface.h   |  80 +++---
 src/xenvkbd/assert.h          |  82 +++---
 src/xenvkbd/bus.c             |  68 ++---
 src/xenvkbd/bus.h             |   6 +-
 src/xenvkbd/dbg_print.h       |  34 +--
 src/xenvkbd/driver.c          |  31 +--
 src/xenvkbd/fdo.c             | 486 +++++++++++++++++-----------------
 src/xenvkbd/fdo.h             |  70 ++---
 src/xenvkbd/frontend.c        | 132 ++++-----
 src/xenvkbd/frontend.h        |  28 +-
 src/xenvkbd/hid.c             | 144 +++++-----
 src/xenvkbd/hid.h             |  20 +-
 src/xenvkbd/mrsw.h            |  24 +-
 src/xenvkbd/mutex.h           |  10 +-
 src/xenvkbd/names.h           |  24 +-
 src/xenvkbd/pdo.c             | 334 +++++++++++------------
 src/xenvkbd/pdo.h             |  76 +++---
 src/xenvkbd/registry.c        | 418 +++++++++++++++++++----------
 src/xenvkbd/registry.h        | 130 ++++-----
 src/xenvkbd/ring.c            | 136 +++++-----
 src/xenvkbd/ring.h            |  32 +--
 src/xenvkbd/thread.c          |  34 +--
 src/xenvkbd/thread.h          |  18 +-
 src/xenvkbd/util.h            |  87 +++---
 31 files changed, 1750 insertions(+), 1620 deletions(-)

--
2.55.0.windows.5



--
Césaire Mounah | Vates Windows Guest Tools Engineer

XCP-ng & Xen Orchestra - Vates solutions

web: https://vates.tech