Xen project Mailing List

Re: [PATCH 0/6] Update SAL annotations in xenhid

To: Césaire Mounah <cesaire.mounah@xxxxxxxxxx>, "win-pv-devel@xxxxxxxxxxxxxxxxxxxx" <win-pv-devel@xxxxxxxxxxxxxxxxxxxx>

From: Owen Smith <owen.smith@xxxxxxxxxx>

Date: Wed, 30 Sep 2026 06:52:38 +0000

Accept-language: en-GB, en-US

Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none

Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=mPCh+qAGbRZTzFU4pUqlnksPmX2cpQpw2CdOaOHbVuI=; b=y7CSfj5kUFJC5CLOkIpVHMmyDl/LMJLRMzq4+ETXU/kbC3+zqhYXjviIQcENrQ2txMcN2oaIF9hFq1VO+thpOJJQEYEsywGavb5ApeNIZoELmRfyMh9ILjOijN9Si5au6szIRBnoknqSYLMPyUC3uoMTMLA7JSQJyhye9FQPzxpYmuOgfPzIEF1tWNxMD1yeFJ15qcBULBOf3BKRtOUUzlQnGUzsZ3MvLz15/A0uchyXCC3Cgfsyc27G6A8hX//cqQcCXb7yKGENXDzvNhQ9G4cc3H6znww6EhWBkcUrXPB5dLnk/TtiWBwzIbyHrhIIfMywRxoaHTysLxOUlG7NUg==

Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=Ylaip4P1/ntmMdvJbYREtNyHknHJ15sw26xAFJFjC6uwpK5j8LiO9BidBN4nfIHshlsXyn0f2O63CLK7aEskXeUr9H4tEOvISjNhbSWpYNt7v1wzG4uikaTEDxjG5CYEi9pdeFO/sovR+Hhy0hMw7a1mGEKgJXuIpP7or3ngqhHbzwdryLlgbt53W4aL8OkaMQ/vfzQKI82lI9aD7zYdQB5rLvdWVmO2Aj9MV5aD+fXKdXjKTSkwSi/IaFoty8itU4RwPRo7beM8UVCdcxZmjyvFafif42c10cYeAttZuJtuZBewHlc4bLaeZBMYvhADbILaO/nc/i5EuIAxKUS+EQ==

Authentication-results: eu.smtp.expurgate.cloud; dkim=pass header.s=selector1 header.d=citrix.com header.i="@citrix.com" header.h="From:Date:Subject:Message-ID:Content-Type:MIME-Version:x-ms-exchange-senderadcheck"

Authentication-results: mx.microsoft.com 1; dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com;

Delivery-date: Wed, 30 Sep 2026 06:52:50 +0000

List-id: Developer list for the Windows PV Drivers subproject <win-pv-devel.lists.xenproject.org>

Msip_labels:

Thread-index: AQHdUDTRVuRaLQRmNkCvm5FxLDdU/bbmr8n3

Thread-topic: [PATCH 0/6] Update SAL annotations in xenhid

This series Reviewed-by: Owen Smith <owen.smith@xxxxxxxxxx> 1 minor change, there was a trailing whitespace in the comment of the last patch I removed this before applying. Owen ________________________________________ From: win-pv-devel <win-pv-devel-bounces@xxxxxxxxxxxxxxxxxxxx> on behalf of Césaire Mounah <cesaire.mounah@xxxxxxxxxx> Sent: 29 September 2026 6:05 PM To: win-pv-devel@xxxxxxxxxxxxxxxxxxxx Cc: Césaire Mounah Subject: [PATCH 0/6] Update SAL annotations in xenhid Update old annotations in the xenhid driver to use SAL 2.0, improving code analysis and correctness. This update follows prior work on xenbus.[1] The series has 3 parts: Part 1: Convert all annotations to SAL 2.0 * xenhid: Convert all annotations to SAL 2.0 * Fix annotations on some parameters Part 2: Update typedefs for better type safety * Update string typedefs Part 3: Fix new warnings introduced by SAL 2.0 * util: sync with xenbus util.h * driver: fix annotations * fdo: suppress warning on *Interface not being updated on success path [1]: https://lists.xenproject.org/archives/html/win-pv-devel/2025-06/msg00049.html Césaire Mounah (6): xenhid: Convert all annotations to SAL 2.0 for better code analysis Fix annotations on some parameters Update string typedefs util: sync with xenbus util.h driver: fix annotations fdo: suppress warning on *Interface not being updated on success path src/xenhid/assert.h | 28 +++---- src/xenhid/dbg_print.h | 20 ++--- src/xenhid/driver.c | 20 ++--- src/xenhid/fdo.c | 168 +++++++++++++++++++++-------------------- src/xenhid/fdo.h | 12 +-- src/xenhid/names.h | 18 ++--- src/xenhid/string.c | 28 +++---- src/xenhid/string.h | 10 +-- src/xenhid/thread.c | 28 +++---- src/xenhid/thread.h | 18 ++--- src/xenhid/util.h | 94 +++++++++++++---------- 11 files changed, 231 insertions(+), 213 deletions(-) -- 2.55.0.windows.5 -- Césaire Mounah | Vates Windows Guest Tools Engineer XCP-ng & Xen Orchestra - Vates solutions web: https://vates.tech

©2013 Xen Project, A Linux Foundation Collaborative Project. All Rights Reserved.
Linux Foundation is a registered trademark of The Linux Foundation.
Xen Project is a trademark of The Linux Foundation.