Re: [PATCH 6/8] monitor: Check allocated pointer, not Context

[Tu Dinh <ngoc-tu.dinh@xxxxxxxxxx>]

On 14/08/2026 09:30, Owen Smith wrote:
> Assisted-by: ClaudeCode:claude-opus-4.8
> Signed-off-by: Owen Smith <owen.smith@xxxxxxxxxx>

Reviewed-by: Tu Dinh <ngoc-tu.dinh@xxxxxxxxxx>

> ---
>   src/monitor/monitor.c | 6 +++---
>   1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/src/monitor/monitor.c b/src/monitor/monitor.c
> index 904badd..b7ee7ba 100644
> --- a/src/monitor/monitor.c
> +++ b/src/monitor/monitor.c
> @@ -1215,7 +1215,7 @@ GetDialogParameters(
>       TitleSize = (MaxValueLength + 1) * sizeof(TCHAR);
>   
>       Context->Title = calloc(1, TitleSize);
> -    if (Context == NULL)
> +    if (Context->Title == NULL)
>           goto fail2;
>   
>       Error = RegQueryValueEx(Context->ParametersKey,
> @@ -1237,7 +1237,7 @@ GetDialogParameters(
>       TextSize = (MaxValueLength + 1) * sizeof (TCHAR);
>   
>       Context->Text = calloc(1, TextSize);
> -    if (Context == NULL)
> +    if (Context->Text == NULL)
>           goto fail5;
>   
>       Error = RegQueryValueEx(Context->ParametersKey,
> @@ -1259,7 +1259,7 @@ GetDialogParameters(
>       QuestionSize = (MaxValueLength + 1) * sizeof (TCHAR);
>   
>       Context->Question = calloc(1, QuestionSize);
> -    if (Context == NULL)
> +    if (Context->Question == NULL)
>           goto fail8;
>   
>       Error = RegQueryValueEx(Context->ParametersKey,



--
Ngoc Tu Dinh | Vates XCP-ng Developer

XCP-ng & Xen Orchestra - Vates solutions

web: https://vates.tech