Re: [PATCH 8/8] Correct printf parameters

[Tu Dinh <ngoc-tu.dinh@xxxxxxxxxx>]

On 14/08/2026 09:30, Owen Smith wrote:
> Adds missing or remove incorrect parameters passed to printf style
> logging calls
> 
> Assisted-by: ClaudeCode:claude-opus-4.8
> Signed-off-by: Owen Smith <owen.smith@xxxxxxxxxx>

Reviewed-by: Tu Dinh <ngoc-tu.dinh@xxxxxxxxxx>

> ---
>   src/xen/bug_check.c | 1 -
>   src/xenbus/fdo.c    | 2 +-
>   src/xenbus/gnttab.c | 1 +
>   3 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/src/xen/bug_check.c b/src/xen/bug_check.c
> index cc77ef0..2a118d3 100644
> --- a/src/xen/bug_check.c
> +++ b/src/xen/bug_check.c
> @@ -760,7 +760,6 @@ BugCheckSystemThreadExceptionNotHandled(
>                         "%s|BUGCHECK: %08X AT %p\n",
>                         __MODULE__,
>                         Code,
> -                      Name,
>                         Address);
>   
>           BugCheckDumpExceptionRecord(Exception);
> diff --git a/src/xenbus/fdo.c b/src/xenbus/fdo.c
> index 2e8f2e6..c86d311 100644
> --- a/src/xenbus/fdo.c
> +++ b/src/xenbus/fdo.c
> @@ -5783,7 +5783,7 @@ FdoSetWatchdog(
>       ConfigFreeSzValue(Option);
>   
>       if (Value && Value < 10) {
> -        Warning("%us TOO SHORT (ROUNDING UP TO 10s)\n");
> +        Warning("%us TOO SHORT (ROUNDING UP TO 10s)\n", Value);
>           Value = 10;
>       }
>   
> diff --git a/src/xenbus/gnttab.c b/src/xenbus/gnttab.c
> index 71f8ec1..3adcef4 100644
> --- a/src/xenbus/gnttab.c
> +++ b/src/xenbus/gnttab.c
> @@ -821,6 +821,7 @@ GnttabDebugCallback(
>           XENBUS_DEBUG(Printf,
>                       &Context->DebugInterface,
>                        "[%u] Address = %08x.%08x\n",
> +                     Index,
>                        Address.HighPart,
>                        Address.LowPart);
>       }



--
Ngoc Tu Dinh | Vates XCP-ng Developer

XCP-ng & Xen Orchestra - Vates solutions

web: https://vates.tech