[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[XENBUS PATCH 2/2] Remove barriers in Acquire/ReleaseHighLock


  • To: win-pv-devel@xxxxxxxxxxxxxxxxxxxx
  • From: Tu Dinh <ngoc-tu.dinh@xxxxxxxxxx>
  • Date: Mon, 18 May 2026 12:25:21 +0200
  • Authentication-results: eu.smtp.expurgate.cloud; dkim=pass header.s=selector1 header.d=vates.tech header.i="@vates.tech" header.h="From:Subject:Date:Message-ID:To:Cc:MIME-Version:Content-Type:In-Reply-To:References:Feedback-ID"
  • Cc: Tu Dinh <ngoc-tu.dinh@xxxxxxxxxx>
  • Delivery-date: Mon, 18 May 2026 10:25:42 +0000
  • Feedback-id: default:8631fc262581453bbf619ec5b2062170:Sweego
  • List-id: Developer list for the Windows PV Drivers subproject <win-pv-devel.lists.xenproject.org>

InterlockedCompareExchange/InterlockedExchange are already full
barriers.

Signed-off-by: Tu Dinh <ngoc-tu.dinh@xxxxxxxxxx>
---
 src/common/high.h | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/src/common/high.h b/src/common/high.h
index 4e21f5b..bdebc7f 100644
--- a/src/common/high.h
+++ b/src/common/high.h
@@ -57,8 +57,6 @@ __AcquireHighLock(
     while (InterlockedCompareExchange(Lock, LOCK_MAGIC, 0) != 0)
         _mm_pause();
 
-    KeMemoryBarrier();
-
     return Irql;
 }
 
@@ -75,8 +73,6 @@ ReleaseHighLock(
     _In_  _IRQL_restores_ KIRQL     Irql
     )
 {
-    KeMemoryBarrier();
-
     InterlockedExchange(Lock, 0);
     KeLowerIrql(Irql);
 }
-- 
2.54.0.windows.1



--
Ngoc Tu Dinh | Vates XCP-ng Developer

XCP-ng & Xen Orchestra - Vates solutions

web: https://vates.tech

 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.