[PATCH] Remove MRSW shared acquire from VifReceiverReturnPacket

[Tu Dinh <ngoc-tu.dinh@xxxxxxxxxx>]

VifReceiverReturnPacket may be called early/late during the enable/
disable sequence respectively. Notably, this can happen during the
exclusive window of VifEnable/VifDisable, and so acquiring a shared lock
via spinning will cause a deadlock.

As ReceiverReturnPacket is protected by the VIF refcount (and in fact
can be called regardless of enabled/disabled state), remove the MRSW
shared lock requirement from it.

Reported-by: Owen Smith <owen.smith@xxxxxxxxxx>
Signed-off-by: Tu Dinh <ngoc-tu.dinh@xxxxxxxxxx>
---
 src/xenvif/vif.c | 5 -----
 1 file changed, 5 deletions(-)

diff --git a/src/xenvif/vif.c b/src/xenvif/vif.c
index 6782cc7..38b6b71 100644
--- a/src/xenvif/vif.c
+++ b/src/xenvif/vif.c
@@ -565,13 +565,8 @@ VifReceiverReturnPacket(
 {
     PXENVIF_VIF_CONTEXT Context = Interface->Context;
 
-    // Called from MINIPORT_RETURN_NET_BUFFER_LISTS
-    SpinAcquireMrswLockShared(&Context->Lock);
-
     ReceiverReturnPacket(FrontendGetReceiver(Context->Frontend),
                          Cookie);
-
-    ReleaseMrswLockShared(&Context->Lock);
 }
 
 static NTSTATUS
-- 
2.54.0.windows.1



--
Ngoc Tu Dinh | Vates XCP-ng Developer

XCP-ng & Xen Orchestra - Vates solutions

web: https://vates.tech