Re: [RFC PATCH 6/6] Remove XenDisk

["Tu Dinh" <ngoc-tu.dinh@xxxxxxxxxx>]

Hi,

On 04/03/2026 09:32, Owen Smith wrote:
> 
> This patch was prepared on the v1 of my series, refactoring the features and 
> disk info,
> it did not apply correctly to the v2 of that series. As this is a 'deletion' 
> patch, the main
> changes needed were updating the to-be-deleted files, and my refactor lost 
> some of
> the whitespace fixes.
> 
> This would likely need replacing should the v2 Refactor Features and DiskInfo 
> be applied,
> but the general intent is good.
> 
> I've run some testing with these patches applied to XenServer's queue, and 
> had good
> results.
> 
> Owen

Would you prefer that I rebase this patch on top of your patch "XenDisk: 
Report Discard support by issuing an Inquiry" or drop that altogether in 
favor of this patch?

> 
> ________________________________________
> From: Tu Dinh <ngoc-tu.dinh@xxxxxxxxxx>
> Sent: 26 February 2026 10:59 AM
> To: win-pv-devel@xxxxxxxxxxxxxxxxxxxx
> Cc: Tu Dinh; Owen Smith
> Subject: [RFC PATCH 6/6] Remove XenDisk
> 
> Windows 8/Server 2012 natively support SCSIOP_UNMAP. XenVbd now also
> correctly handles the reporting to enable unmap support. As such, the
> functionality provided by XenDisk is no longer needed.
> 
> Signed-off-by: Tu Dinh <ngoc-tu.dinh@xxxxxxxxxx>
> ---
>   msbuild.ps1                         |    2 +-
>   src/xendisk/assert.h                |  220 ---
>   src/xendisk/debug.h                 |   95 --
>   src/xendisk/driver.c                |  283 ----
>   src/xendisk/driver.h                |   76 -
>   src/xendisk/fdo.c                   | 1618 ----------------------
>   src/xendisk/fdo.h                   |   84 --
>   src/xendisk/mutex.h                 |  114 --
>   src/xendisk/pdo.c                   | 2000 ---------------------------
>   src/xendisk/pdo.h                   |   77 --
>   src/xendisk/registry.c              | 1564 ---------------------
>   src/xendisk/registry.h              |  211 ---
>   src/xendisk/thread.c                |  226 ---
>   src/xendisk/thread.h                |   75 -
>   src/xendisk/types.h                 |   54 -
>   src/xendisk/xendisk.rc              |   57 -
>   src/xenvbd.inf                      |  118 +-
>   src/xenvbd/target.c                 |    6 +-
>   vs2019/package/package.vcxproj      |    3 -
>   vs2019/xendisk/xendisk.vcxproj      |   83 --
>   vs2019/xendisk/xendisk.vcxproj.user |    8 -
>   vs2019/xenvbd.sln                   |   14 -
>   vs2022/package/package.vcxproj      |    3 -
>   vs2022/xendisk/xendisk.vcxproj      |   76 -
>   vs2022/xendisk/xendisk.vcxproj.user |    8 -
>   vs2022/xenvbd.sln                   |   10 -
>   26 files changed, 52 insertions(+), 7033 deletions(-)
>   delete mode 100644 src/xendisk/assert.h
>   delete mode 100644 src/xendisk/debug.h
>   delete mode 100644 src/xendisk/driver.c
>   delete mode 100644 src/xendisk/driver.h
>   delete mode 100644 src/xendisk/fdo.c
>   delete mode 100644 src/xendisk/fdo.h
>   delete mode 100644 src/xendisk/mutex.h
>   delete mode 100644 src/xendisk/pdo.c
>   delete mode 100644 src/xendisk/pdo.h
>   delete mode 100644 src/xendisk/registry.c
>   delete mode 100644 src/xendisk/registry.h
>   delete mode 100644 src/xendisk/thread.c
>   delete mode 100644 src/xendisk/thread.h
>   delete mode 100644 src/xendisk/types.h
>   delete mode 100644 src/xendisk/xendisk.rc
>   delete mode 100644 vs2019/xendisk/xendisk.vcxproj
>   delete mode 100644 vs2019/xendisk/xendisk.vcxproj.user
>   delete mode 100644 vs2022/xendisk/xendisk.vcxproj
>   delete mode 100644 vs2022/xendisk/xendisk.vcxproj.user
> 


--
Ngoc Tu Dinh | Vates XCP-ng Developer

XCP-ng & Xen Orchestra - Vates solutions

web: https://vates.tech