[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 1/3] XenDisk: Report Discard support by issuing an Inquiry
- To: Tu Dinh <ngoc-tu.dinh@xxxxxxxxxx>, "win-pv-devel@xxxxxxxxxxxxxxxxxxxx" <win-pv-devel@xxxxxxxxxxxxxxxxxxxx>
- From: Owen Smith <owen.smith@xxxxxxxxxx>
- Date: Tue, 24 Feb 2026 15:10:15 +0000
- Accept-language: en-GB, en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=UsTfvAYMOR94OuVonO3HuQoboAndvw3SLhB3z7Yylrk=; b=LXCH4Cc2F4JF+lfk1YXLw3ugWAFJefeRYGpQfnnrBYPggk2f1fSD/6LYI++7zOxyNL8GTkLjhcTN5sdxUl/bQHb3NxX5G0NtDwbjphTVz8vMgUOePA3cGiDtueKoXAEPu5ZojHSUCl1qIB1L5tJjVnDD2LiWWn2uNq5cbaykrSdhhss6erR1VxHzSmQVqdru3FIEJLa49LCPgRlRvdcM+7Zj6artjfDjp4m5p+LI+Gp2qNlPKuMRSTo0gkYkKoBAF4oMqbqQkhMRRnvNoFdqT3Bcme41MxnM1xl5bPlPJbdEQImKZQD99E77Q7RGXxPGE1OALc1NZPF77bhDpk+yWA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=roaxyYjck05Xq2v3bnpZJUqzOSOKYSmCO8aCDCZwYk7vCNpWWh/a7OVEBiEANpO2RHEZYH/GhKm2A6gSz3McE5W/pxxJXUMWE1CFmVcGGyguOlFwbIhhEgCYzT9VktOx7s/8Wj2/5fw4BG6koljmRaW0/RL2EjthIMvJu98tS2fbMmnV755dfLajnIvM8KniIXnJ0L8QQUBolNM4iq+LlsDfnOIWj2GMe7EnqFQcqPqzxlO8k+uWUN+iLK7QUgirAq4jqFMHAWJ3ksQ2/xcNJ8v0Jz00Mj4GNpeO1LEd8IYWMrpACXAyJiwsMYYEKxJS9iUR84pgVhTR47pBcs/kdg==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com;
- Cc: Owen Smith <owen.smith@xxxxxxxxx>
- Delivery-date: Tue, 24 Feb 2026 15:10:32 +0000
- List-id: Developer list for the Windows PV Drivers subproject <win-pv-devel.lists.xenproject.org>
- Msip_labels:
- Thread-index: AQHcoa2igq790CK2pEeqs28w9wVVLrWLW8AAgAafWVk=
- Thread-topic: [PATCH 1/3] XenDisk: Report Discard support by issuing an Inquiry
> From: Owen Smith <owen.smith@xxxxxxxxx>
>
> When XenDisk starts, issue an inquiry to determine the status of discard
> support in the backend. If the backend exposes discard support, allow
> XenDisk to respond to the appropriate property requests, and forward the
> trim requests to XenVbd.
>
> Signed-off-by: Owen Smith <owen.smith@xxxxxxxxxx>
I might have missed something, but isn't this already done in xenvbd's
TargetUnmap, and so xendisk shouldn't need to probe this by itself?
Also, at this point I wonder which other feature could we remove from
xendisk and fold into xenvbd instead.
IIRC, storport didnt expose discard support correctly, and we needed
xendisk to intercept discard requests and build the SRBs which pass
through storport.
This patch allows xendisk to query xenvbd's (and the backend's) support
for discard, and skips parsing discard requests for a backend that doesnt
support them.
Owen
|
