Re: [PATCH 4/5] registry: use RegCloseKey for RequestKey and ParametersKey

["Tu Dinh" <ngoc-tu.dinh@xxxxxxxxxx>]

On 06/02/2026 09:45, Owen Smith wrote:
> From: david ambu <david.preetham@xxxxxxxxx>
> 
> CloseHandle silently fails for HKEY.
> 
> Signed-off-by: david ambu <david.preetham@xxxxxxxxx>

IMO this could go in ahead of the other changes.

As such, it should be moved first so that it's not blocked by the other 
patches.

Could you fix this for Xencons as well?

> ---
>   src/monitor/monitor.c | 10 ++++++----
>   1 file changed, 6 insertions(+), 4 deletions(-)
> 
> diff --git a/src/monitor/monitor.c b/src/monitor/monitor.c
> index 61945f0..77d7dd8 100644
> --- a/src/monitor/monitor.c
> +++ b/src/monitor/monitor.c
> @@ -1743,7 +1743,8 @@ done:
>       free(Context->Question);
>       free(Context->Text);
>       free(Context->Title);
> -    CloseHandle(Context->RequestKey);
> +
> +    RegCloseKey(Context->RequestKey);
>       free(RequestKeyName);
>       CloseHandle(Context->ResponseEvent);
>       CloseHandle(Context->RequestEvent);
> @@ -1753,7 +1754,8 @@ done:
>   
>       (VOID) DeregisterEventSource(Context->EventLog);
>   
> -    CloseHandle(Context->ParametersKey);
> +    RegCloseKey(Context->ParametersKey);
> +
>       (VOID) RemoveStartOverride("stornvme");
>       (VOID) RemoveAllStartOverrides();
>   
> @@ -1772,7 +1774,7 @@ fail11:
>   fail10:
>       Log("fail10");
>   
> -    CloseHandle(Context->RequestKey);
> +    RegCloseKey(Context->RequestKey);
>   
>   fail9:
>       Log("fail9");
> @@ -1810,7 +1812,7 @@ fail3:
>   fail2:
>       Log("fail2");
>   
> -    CloseHandle(Context->ParametersKey);
> +    RegCloseKey(Context->ParametersKey);
>   
>   fail1:
>       Error = GetLastError();



--
Ngoc Tu Dinh | Vates XCP-ng Developer

XCP-ng & Xen Orchestra - Vates solutions

web: https://vates.tech