[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] Use BootFlags directive on build 25398 and later


  • To: Tu Dinh <ngoc-tu.dinh@xxxxxxxxxx>, "win-pv-devel@xxxxxxxxxxxxxxxxxxxx" <win-pv-devel@xxxxxxxxxxxxxxxxxxxx>
  • From: Owen Smith <owen.smith@xxxxxxxxxx>
  • Date: Tue, 25 Nov 2025 14:34:44 +0000
  • Accept-language: en-GB, en-US
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=+NxIhd1ufmH2LrvERvSj4IXcK4suzgrjQmrOEDfBpzE=; b=E3nA4G38NegVenoMlqIFkXla48AmaNvfWR9DiD8iUTo9C7sxokf/6Cx6UK3AsgAaVHlUXetPZYQr2fQ7PreDqedkEV4l9CZpcnA5aZFVnGOIgWIjyk014/BiRlaQEmyrxg3C5QAMdt69d6UjWP5dHm9b4DYZOkYzIGWZXGNquuw4QJyAcBItvq6coMhWbUDxqjBQ83Hz0Ah8fD6Vpil0d6Dq9f9Z9Sdbh+4sYtCIlWFR745IER8ZAavnEMsfmLWWqJ/XZvpN4RNhjVLINrBSzprG7eqkF7abiRjxJDcd3V1N6y8in8Rfc1/Y1h6sPh7vnVA15Bj229dwUxKLjleJww==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=f7RUDqzehFSBNzVrJc4+NkX7Bds6Dvy+smcpp1cChyFua313hlY3zOt290pE75zq7XRVwqhAzV3biiO5H+jNT3Jyv95QPyNZGOsghuQ6rNdbtD1nElkQ1lXssJFCDfn8AqHDlszntzfzb2CqYN0M+foMUWAaScH6WVDAiQuyV5pxMYU3c5bjYThGuYa/4qzcythQBZIl4el8q6Jeov0uPc8r7uoc3R9JEPQkzIFppCzyhaFm6uLMsLNxKgvK39e9F6Nwx572avdlq2FF90uwe+yZ/+fkK8AogddIQ9URnwvxCCIwLQv9xxy/pEf4EfCqSq48zWUbTPHyTt51ZLu5fw==
  • Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com;
  • Delivery-date: Tue, 25 Nov 2025 14:34:50 +0000
  • List-id: Developer list for the Windows PV Drivers subproject <win-pv-devel.lists.xenproject.org>
  • Msip_labels:
  • Thread-index: AQHcXUlbmtBnLEWOx0alTS3TmhsKyrUDdf7X
  • Thread-topic: [PATCH] Use BootFlags directive on build 25398 and later

I'm not aware of any use-case where xencons is used as a boot path, so 
BootFlags in this inf is not required - its likely a copy-paste issue from 
creation, when xenvif was used as a template. In most cases, xencons wont be 
particularly useful until xencons_monitor has started, as this spawns 
xencons_tty to create the shell.

Owen

________________________________________
From: win-pv-devel <win-pv-devel-bounces@xxxxxxxxxxxxxxxxxxxx> on behalf of Tu 
Dinh <ngoc-tu.dinh@xxxxxxxxxx>
Sent: 24 November 2025 1:50 PM
To: win-pv-devel@xxxxxxxxxxxxxxxxxxxx
Cc: Tu Dinh
Subject: [PATCH] Use BootFlags directive on build 25398 and later

Setting BootFlags in an AddReg section is no longer allowed by INFVerif.

This requires duplication of some INF sections upstream from
XenCons_Service.

Link: 
https://techcommunity.microsoft.com/blog/hardware-dev-center/driver-isolation-ruleset-changes-for-whcp-and-attestation-submissions/4461580
Signed-off-by: Tu Dinh <ngoc-tu.dinh@xxxxxxxxxx>
---
 src/xencons.inf | 29 ++++++++++++++++++++++++++++-
 1 file changed, 28 insertions(+), 1 deletion(-)

diff --git a/src/xencons.inf b/src/xencons.inf
index bae7624..4e8d274 100644
--- a/src/xencons.inf
+++ b/src/xencons.inf
@@ -62,7 +62,7 @@ 
xencons_monitor_@MAJOR_VERSION@_@MINOR_VERSION@_@MICRO_VERSION@_@BUILD_NUMBER@.d
 
xencons_tty_@MAJOR_VERSION@_@MINOR_VERSION@_@MICRO_VERSION@_@BUILD_NUMBER@.exe,xencons_tty.exe

 [Manufacturer]
-%Vendor%=Inst,NT@INF_ARCH@
+%Vendor%=Inst,NT@INF_ARCH@,NT@INF_ARCH@.10.0...25398

 [Inst.NT@INF_ARCH@]
 %XenConsName%=XenCons_Inst,\
@@ -70,6 +70,12 @@ 
XENBUS\VEN_@VENDOR_PREFIX@@VENDOR_DEVICE_ID@&DEV_CONS&REV_0900000A,\
 XENBUS\VEN_@VENDOR_PREFIX@0001&DEV_CONS&REV_0900000A,\
 XENBUS\VEN_@VENDOR_PREFIX@0002&DEV_CONS&REV_0900000A

+[Inst.NT@INF_ARCH@.10.0...25398]
+%XenConsName%=XenCons_Inst_25H2,\
+XENBUS\VEN_@VENDOR_PREFIX@@VENDOR_DEVICE_ID@&DEV_CONS&REV_0900000A,\
+XENBUS\VEN_@VENDOR_PREFIX@0001&DEV_CONS&REV_0900000A,\
+XENBUS\VEN_@VENDOR_PREFIX@0002&DEV_CONS&REV_0900000A
+
 [XenCons_Inst]
 CopyFiles=XenCons_Copyfiles
 CopyFiles=Monitor_Copyfiles
@@ -77,6 +83,13 @@ CopyFiles=Tty_Copyfiles
 ; TODO: Remove during next PDO version bump
 FeatureScore=0xFE

+[XenCons_Inst_25H2]
+CopyFiles=XenCons_Copyfiles
+CopyFiles=Monitor_Copyfiles
+CopyFiles=Tty_Copyfiles
+; TODO: Remove during next PDO version bump
+FeatureScore=0xFE
+
 [XenCons_Copyfiles]
 xencons.sys

@@ -84,6 +97,10 @@ xencons.sys
 
AddService=xencons_monitor,%SPSVCSINST_STARTSERVICE%,Monitor_Service,Monitor_EventLog
 AddService=xencons,%SPSVCINST_ASSOCSERVICE%,XenCons_Service

+[XenCons_Inst_25H2.Services]
+AddService=xencons_monitor,%SPSVCSINST_STARTSERVICE%,Monitor_Service,Monitor_EventLog
+AddService=xencons,%SPSVCINST_ASSOCSERVICE%,XenCons_Service_25H2
+
 [XenCons_Service]
 DisplayName=%XenConsName%
 ServiceType=%SERVICE_KERNEL_DRIVER%
@@ -93,6 +110,16 @@ ServiceBinary=%12%\xencons.sys
 LoadOrderGroup="Extended Base"
 AddReg = XenCons_BootFlags, XenCons_Parameters

+[XenCons_Service_25H2]
+DisplayName=%XenConsName%
+ServiceType=%SERVICE_KERNEL_DRIVER%
+StartType=%SERVICE_DEMAND_START%
+ErrorControl=%SERVICE_ERROR_NORMAL%
+ServiceBinary=%12%\xencons.sys
+LoadOrderGroup="Extended Base"
+AddReg = XenCons_Parameters
+BootFlags = 0x81
+
 [XenCons_BootFlags]
 HKR,,"BootFlags",0x00010003,0x81

--
2.51.2.windows.1



--
Ngoc Tu Dinh | Vates XCP-ng Developer

XCP-ng & Xen Orchestra - Vates solutions

web: https://vates.tech





 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.