[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[XENVIF PATCH v2 0/3] Fix controller timeouts



4e080f819b55 "Skip hash update if frontend is not enabled" broke RSS, since NDIS
queries the supported hash types before the frontend is enabled, and since
controller requests are not dependent on the frontend being enabled to begin
with.

Still, we need to handle situations where the backend no longer responds to
control requests (e.g. when it has disappeared following a forced unplug).

Revert the above patch in favor of the following unplug fixes:
* Limit the retry in ControllerGetResponse to 5 seconds instead of waiting
  forever, to fix the hang issue on forced unplug;
* Check for Controller->Enabled in ControllerPutRequest. This will not help in
  case the backend has disappeared, but should help in other cases of spurious
  control requests.

v2:
* Extend ControllerGetResponse timeout to 5 secs
* Add ControllerPutRequest check

Tu Dinh (3):
  Revert 4e080f819b55 "Skip hash update if front...
  Limit retry in ControllerGetResponse
  Check controller enable status in PutRequest

 src/xenvif/controller.c | 51 ++++++++++++++++++++++++++++++++++-------
 src/xenvif/frontend.c   |  3 ---
 2 files changed, 43 insertions(+), 11 deletions(-)

--
2.51.0.windows.2


--
Ngoc Tu Dinh | Vates XCP-ng Developer

XCP-ng & Xen Orchestra - Vates solutions

web: https://vates.tech




 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.