[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [XENCONS PATCH 00/11] Use SAL 2.0 annotations
All the patches in this series
On Wed, Sep 10, 2025 at 12:23 PM Tu Dinh <ngoc-tu.dinh@xxxxxxxxxx> wrote:
WinPV drivers use old annotations (IN/OUT) that are not checked by the compiler.
Convert them to SAL2 for better checking with Code Analysis.
Same as the Xenbus series, this series is split into several parts:
Part 1: Sync converted headers from Xenbus
* Sync interface headers from Xenbus
* Sync Registry implementation with Xenbus
* Sync thread.[ch] from Xenbus
* Sync utility headers from Xenbus
Part 2: Convert existing annotations
* Replace old annotations with SAL2 equivalents
* Switch from CHAR*/WCHAR* to PSTR/PWSTR
Part 3: Suppress new warnings
* Suppress uninitialized *Interface warning in FdoQueryInterface
* Suppress warnings with SYSTEM_POWER_STATE asserts
Part 4: Various fixes discovered via SAL annotations
* Check for IoAttachDeviceToDeviceStack failure in FdoCreate
* monitor: Fix GetExecutable allocation check
* Fix CSQ lock annotations
Tu Dinh (11):
Sync interface headers from Xenbus
Sync Registry implementation with Xenbus
Sync thread.[ch] from Xenbus
Sync utility headers from Xenbus
Replace old annotations with SAL2 equivalents
Switch from CHAR*/WCHAR* to PSTR/PWSTR
Suppress uninitialized *Interface warning in FdoQueryInterface
Suppress warnings with SYSTEM_POWER_STATE asserts
Check for IoAttachDeviceToDeviceStack failure in FdoCreate
monitor: Fix GetExecutable allocation check
Fix CSQ lock annotations
include/cache_interface.h | 76 +++----
include/console_interface.h | 30 +--
include/debug_interface.h | 30 +--
include/evtchn_interface.h | 72 +++---
include/gnttab_interface.h | 88 ++++----
include/store_interface.h | 84 +++----
include/suspend_interface.h | 24 +-
src/monitor/monitor.c | 138 ++++++------
src/tty/tty.c | 46 ++--
src/xencons/assert.h | 34 +--
src/xencons/console.c | 76 +++----
src/xencons/console.h | 10 +-
src/xencons/console_abi.h | 20 +-
src/xencons/dbg_print.h | 35 +--
src/xencons/driver.c | 35 +--
src/xencons/fdo.c | 435 ++++++++++++++++++------------------
src/xencons/fdo.h | 38 ++--
src/xencons/frontend.c | 154 ++++++-------
src/xencons/frontend.h | 22 +-
src/xencons/mutex.h | 4 +-
src/xencons/names.h | 36 +--
src/xencons/pdo.c | 280 +++++++++++------------
src/xencons/pdo.h | 40 ++--
src/xencons/registry.c | 348 ++++++++++++++++++++---------
src/xencons/registry.h | 144 ++++++------
src/xencons/ring.c | 147 ++++++------
src/xencons/ring.h | 30 +--
src/xencons/stream.c | 71 +++---
src/xencons/stream.h | 10 +-
src/xencons/thread.c | 40 ++--
src/xencons/thread.h | 18 +-
src/xencons/util.h | 90 ++++----
32 files changed, 1444 insertions(+), 1261 deletions(-)
--
2.51.0.windows.1
--
Ngoc Tu Dinh | Vates XCP-ng Developer
XCP-ng & Xen Orchestra - Vates solutions
web: https://vates.tech
|
