[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[PATCH 2/2] Fix CodeAnalysis issues



* RegistryInitialize is incorrectly detected as DRIVER_INITIALIZE
* Add ASSERT to avoid detection of potential NULL pointer access

Signed-off-by: Owen Smith <owen.smith@xxxxxxxxx>
---
 src/xeniface/ioctl_gnttab.c | 1 +
 src/xeniface/registry.c     | 1 +
 2 files changed, 2 insertions(+)

diff --git a/src/xeniface/ioctl_gnttab.c b/src/xeniface/ioctl_gnttab.c
index 026f29b..ef77295 100644
--- a/src/xeniface/ioctl_gnttab.c
+++ b/src/xeniface/ioctl_gnttab.c
@@ -387,6 +387,7 @@ IoctlGnttabPermitForeignAccess(
     In = NULL;
 
     if (ControlCode == IOCTL_XENIFACE_GNTTAB_PERMIT_FOREIGN_ACCESS) {
+        ASSERT3P(In1, !=, NULL);
         Context->UseRequestId = TRUE;
         Context->RequestId = In1->RequestId;
         __FreeCapturedBuffer(In1);
diff --git a/src/xeniface/registry.c b/src/xeniface/registry.c
index 1ab85c9..423c4cc 100644
--- a/src/xeniface/registry.c
+++ b/src/xeniface/registry.c
@@ -62,6 +62,7 @@ __RegistryFree(
 }
 
 NTSTATUS
+#pragma prefast(suppress:28101) // unannotated DriverEntry function
 RegistryInitialize(
     IN  PDRIVER_OBJECT  DriverObject,
     IN  PUNICODE_STRING Path
-- 
2.50.1.windows.1




 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.