[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2 3/3] Always run Code Analysis on build

To: Tu Dinh <ngoc-tu.dinh@xxxxxxxxxx>
From: Owen Smith <owen.smith@xxxxxxxxx>
Date: Mon, 21 Jul 2025 08:09:33 +0100
Cc: win-pv-devel@xxxxxxxxxxxxxxxxxxxx
Delivery-date: Mon, 21 Jul 2025 07:09:50 +0000
List-id: Developer list for the Windows PV Drivers subproject <win-pv-devel.lists.xenproject.org>

We'll skip this patch and apply the previous 2.

I seem to recall similar issues in XenServer builds with code analysis that required originally running code analysis separate from SDV. 

Owen

On Mon, Jul 7, 2025 at 11:15 AM Tu Dinh <ngoc-tu.dinh@xxxxxxxxxx> wrote:

On 05/07/2025 19:00, Tu Dinh wrote:
> Code Analysis is quick to run, and there's little reason not to run it.
> Unconditionally run the recommended driver ruleset on build.
>
> Signed-off-by: Tu Dinh <ngoc-tu.dinh@xxxxxxxxxx>

Unfortunately this doesn't build on GitHub Actions due to
%WindowsSdkDir% not being set.

Ngoc Tu Dinh | Vates XCP-ng Developer

XCP-ng & Xen Orchestra - Vates solutions

web: https://vates.tech

References:
- [PATCH v2 0/3] CI integration for Windows PV drivers
  - From: Tu Dinh
- [PATCH v2 3/3] Always run Code Analysis on build
  - From: Tu Dinh
- Re: [PATCH v2 3/3] Always run Code Analysis on build
  - From: Tu Dinh

Prev by Date: Re: [PATCH v2 2/3] Throw on build command failure instead of exiting
Next by Date: Re: [XENIFACE PATCH v2] xenagent: Add TimeSyncMode option
Previous by thread: Re: [PATCH v2 3/3] Always run Code Analysis on build
Next by thread: [PATCH v2 2/3] Throw on build command failure instead of exiting
Index(es):
- Date
- Thread

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.