Re: [PATCH] FdoCreate: bad memset in failure path.

[Paul Durrant <xadimgnik@xxxxxxxxx>]

On 17/11/2022 10:39, Owen Smith wrote:
> -----Original Message-----
> From: win-pv-devel <win-pv-devel-bounces@xxxxxxxxxxxxxxxxxxxx> On Behalf Of 
> Rabish Kumar (3P)
> Sent: 16 November 2022 16:14
> To: win-pv-devel@xxxxxxxxxxxxxxxxxxxx
> Cc: Rabish Kumar (3P) <Rabish.Kumar@xxxxxxxxxx>
> Subject: [PATCH] FdoCreate: bad memset in failure path.
>
> [CAUTION - EXTERNAL EMAIL] DO NOT reply, click links, or open attachments 
> unless you have verified the sender and know the content is safe.
>
> Signed-off-by: Rabish Kumar <rabish.kumar@xxxxxxxxxx>
>
>
> Fail14 attempts to clear the wrong interface - possibly leading to the ASSERT 
> at line 3249 asserting
> Acked-by: Owen Smith <owen.smith@xxxxxxxxxx>
With Owen's amendment to the commit message...

Acked-by: Paul Durrant <paul@xxxxxxx>

> ---
>   src/xenvif/fdo.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/src/xenvif/fdo.c b/src/xenvif/fdo.c index 8067e03..b684c7b 100644
> --- a/src/xenvif/fdo.c
> +++ b/src/xenvif/fdo.c
> @@ -3173,8 +3173,8 @@ FdoCreate(
>   fail14:
>       Error("fail14\n");
>   
> -    RtlZeroMemory(&Fdo->UnplugInterface,
> -                  sizeof (XENBUS_UNPLUG_INTERFACE));
> +    RtlZeroMemory(&Fdo->GnttabInterface,
> +                  sizeof (XENBUS_GNTTAB_INTERFACE));
>   
>   fail13:
>       Error("fail13\n");
> --
> 2.37.2.windows.2