|
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [PATCH] Add ring disconnect logging.
Logging to note error cases which would otherwise be silent in release builds.
This aids greatly with customer debugging.
Signed-off-by: Martin Harvey <martin.harvey@xxxxxxxxxx>
---
src/xenvif/receiver.c | 9 +++++++++
src/xenvif/transmitter.c | 4 ++++
2 files changed, 13 insertions(+)
diff --git a/src/xenvif/receiver.c b/src/xenvif/receiver.c
index c70d938..123b2d7 100644
--- a/src/xenvif/receiver.c
+++ b/src/xenvif/receiver.c
@@ -2887,6 +2887,15 @@ __ReceiverRingDisconnect(
ASSERT3U(Ring->ResponsesProcessed, ==, Ring->RequestsPushed);
ASSERT3U(Ring->RequestsPushed, ==, Ring->RequestsPosted);
+ //Debug logs as well as assertion, else customer debugging difficult.
+ if ((Ring->ResponsesProcessed != Ring->RequestsPushed) ||
+ (Ring->RequestsPushed != Ring->RequestsPosted))
+ {
+ XENBUS_DEBUG(Trigger,
+ &Receiver->DebugInterface,
+ Ring->DebugCallback);
+ }
+
Ring->ResponsesProcessed = 0;
Ring->RequestsPushed = 0;
Ring->RequestsPosted = 0;
diff --git a/src/xenvif/transmitter.c b/src/xenvif/transmitter.c
index de9b476..abda21b 100644
--- a/src/xenvif/transmitter.c
+++ b/src/xenvif/transmitter.c
@@ -4005,6 +4005,10 @@ __TransmitterRingDisable(
}
if (Ring->ResponsesProcessed != Ring->RequestsPushed)
{
+ XENBUS_DEBUG(Trigger,
+ &Transmitter->DebugInterface,
+ Ring->DebugCallback);
+
__TransmitterRingFakeResponses(Ring);
(VOID) TransmitterRingPoll(Ring);
}
--
2.25.0.windows.1
|
![]() |
Lists.xenproject.org is hosted with RackSpace, monitoring our |