RE: [PATCH 2/2] Inherit versioning info from environment if present

[Paul Durrant <xadimgnik@xxxxxxxxx>]

> -----Original Message-----
> From: Owen Smith <owen.smith@xxxxxxxxxx>
> Sent: 09 November 2020 08:11
> To: Nicholas Tsirakis <niko.tsirakis@xxxxxxxxx>; 
> win-pv-devel@xxxxxxxxxxxxxxxxxxxx
> Cc: paul@xxxxxxx; Ben Chalmers <ben.chalmers@xxxxxxxxxx>; Nicholas Tsirakis 
> <tsirakisn@xxxxxxxxxxxx>
> Subject: RE: [PATCH 2/2] Inherit versioning info from environment if present
> 
> I'm currently looking at carrying the exact same changes in my patch queue, 
> so that the patch queue
> version can be used. In my case, I have no intentions of changing the Major 
> or Minor versions (for
> consistency)
> 
> Acked-by: Owen Smith <owen.smith@xxxxxxxxxx>
> 
> > -----Original Message-----
> > From: Nicholas Tsirakis <niko.tsirakis@xxxxxxxxx>
> > Sent: 06 November 2020 20:49
> > To: win-pv-devel@xxxxxxxxxxxxxxxxxxxx
> > Cc: paul@xxxxxxx; Ben Chalmers <ben.chalmers@xxxxxxxxxx>; Owen Smith
> > <owen.smith@xxxxxxxxxx>; Nicholas Tsirakis <tsirakisn@xxxxxxxxxxxx>
> > Subject: [PATCH 2/2] Inherit versioning info from environment if present
> >
> > [CAUTION - EXTERNAL EMAIL] DO NOT reply, click links, or open attachments
> > unless you have verified the sender and know the content is safe.
> >
> > As the drivers stabilize and mature, there is an ever-growing chance that 
> > other
> > opensource virtualization projects will adopt them. Allow external projects 
> > to
> > inject their own versioning into the drivers instead of hardcoding the 
> > latest
> > winpv version.
> >
> > Signed-off-by: Nicholas Tsirakis <tsirakisn@xxxxxxxxxxxx>

Also...

Acked-by: Paul Durrant <paul@xxxxxxx>

> > ---
> >  build.ps1 | 14 +++++++++++---
> >  1 file changed, 11 insertions(+), 3 deletions(-)
> >
> > diff --git a/build.ps1 b/build.ps1
> > index 06626fd..b7b015f 100644
> > --- a/build.ps1
> > +++ b/build.ps1
> > @@ -79,9 +79,17 @@ if ([string]::IsNullOrEmpty($Env:BUILD_NUMBER)) {
> >     Set-Item -Path Env:BUILD_NUMBER -Value $BuildNum  }
> >
> > -Set-Item -Path Env:MAJOR_VERSION -Value '9'
> > -Set-Item -Path Env:MINOR_VERSION -Value '1'
> > -Set-Item -Path Env:MICRO_VERSION -Value '0'
> > +if ([string]::IsNullOrEmpty($Env:MAJOR_VERSION)) {
> > +   Set-Item -Path Env:MAJOR_VERSION -Value '9'
> > +}
> > +
> > +if ([string]::IsNullOrEmpty($Env:MINOR_VERSION)) {
> > +   Set-Item -Path Env:MINOR_VERSION -Value '1'
> > +}
> > +
> > +if ([string]::IsNullOrEmpty($Env:MICRO_VERSION)) {
> > +   Set-Item -Path Env:MICRO_VERSION -Value '0'
> > +}
> >
> >  if ($Arch -eq "" -or $Arch -eq "x86" -or $Arch -eq "Win32") {
> >     Build "x86" $Type
> > --
> > 2.25.4
> >