[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] Fix HID code for KEY_SYSRQ.
Usage 0x46 is mapped to "Keyboard PrintScreen" according to a HID usage reference (Section 10, page 53 of https://www.usb.org/sites/default/files/documents/hut1_12v2.pdf). My test keyboards have one button for PrtSc/SysRq (and a separate one for Pause/Break), and without this patch, pressing PrtSc sends Pause instead of PrtSc in contrast with the qemu device and bare metal. Troy
I don't have a standard keyboard in front of me, but I think Pause/SysRq is the right labelling, and there is no current mapping to HID usage 0x46.
Acked-by: Owen Smith <owen.smith@xxxxxxxxxx>
> -----Original Message-----
> From: Troy Crosley <troycrosley@xxxxxxxxx>
> Sent: 13 October 2020 23:25
> To: win-pv-devel@xxxxxxxxxxxxxxxxxxxx
> Cc: paul@xxxxxxx; Ben Chalmers <ben.chalmers@xxxxxxxxxx>; Owen Smith
> <owen.smith@xxxxxxxxxx>; Troy Crosley <troycrosley@xxxxxxxxx>
> Subject: [PATCH] Fix HID code for KEY_SYSRQ.
>
> [CAUTION - EXTERNAL EMAIL] DO NOT reply, click links, or open attachments
> unless you have verified the sender and know the content is safe.
>
> Signed-off-by: Troy Crosley <troycrosley@xxxxxxxxx>
> ---
> src/xenvkbd/vkbd.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/xenvkbd/vkbd.h b/src/xenvkbd/vkbd.h index fa4cd7f..7cec2d0
> 100644
> --- a/src/xenvkbd/vkbd.h
> +++ b/src/xenvkbd/vkbd.h
> @@ -227,7 +227,7 @@ static const HID_DEVICE_ATTRIBUTES
> VkbdDeviceAttributes = {
> DEFINE_USAGE(KEY_KPENTER, 0x58), \
> DEFINE_USAGE(KEY_RIGHTCTRL, 0xE4), \
> DEFINE_USAGE(KEY_KPSLASH, 0x54), \
> - DEFINE_USAGE(KEY_SYSRQ, 0x48), \
> + DEFINE_USAGE(KEY_SYSRQ, 0x46), \
> DEFINE_USAGE(KEY_PAUSE, 0x48), \
> DEFINE_USAGE(KEY_RIGHTALT, 0xE6), \
> DEFINE_USAGE(KEY_HOME, 0x4A), \
> --
> 2.20.1
>
|
