Re: [win-pv-devel] [PATCH] Handle return codes from MSBuild

[Paul Durrant <xadimgnik@xxxxxxxxx>]

> -----Original Message-----
> From: win-pv-devel <win-pv-devel-bounces@xxxxxxxxxxxxxxxxxxxx> On Behalf Of 
> Owen Smith
> Sent: 10 March 2020 10:47
> To: win-pv-devel@xxxxxxxxxxxxxxxxxxxx
> Cc: Owen Smith <owen.smith@xxxxxxxxxx>
> Subject: [win-pv-devel] [PATCH] Handle return codes from MSBuild
> 
> If MSBuild fails, it returns a non-zero return value. Forward this
> failure to the calling scripts to fail earlier.
> 
> Signed-off-by: Owen Smith <owen.smith@xxxxxxxxxx>

Acked-by: Paul Durrant <paul@xxxxxxx>

Presumably this ought to be applied to all drivers?

> ---
>  build.ps1   | 4 ++++
>  msbuild.ps1 | 4 ++++
>  2 files changed, 8 insertions(+)
> 
> diff --git a/build.ps1 b/build.ps1
> index cc352e0..c66ac05 100644
> --- a/build.ps1
> +++ b/build.ps1
> @@ -29,6 +29,10 @@ Function Build {
>               Type = $Type
>               }
>       & ".\msbuild.ps1" @params
> +     if ($LASTEXITCODE -ne 0) {
> +             Write-Host -ForegroundColor Red "ERROR: Build failed, code:" 
> $LASTEXITCODE
> +             Exit $LASTEXITCODE
> +     }
>  }
> 
>  Function SdvBuild {
> diff --git a/msbuild.ps1 b/msbuild.ps1
> index 17c1a3b..670050c 100644
> --- a/msbuild.ps1
> +++ b/msbuild.ps1
> @@ -31,6 +31,10 @@ Function Run-MSBuild {
>       $c += Join-Path -Path $SolutionPath -ChildPath $Name
> 
>       Invoke-Expression $c
> +     if ($LASTEXITCODE -ne 0) {
> +             Write-Host -ForegroundColor Red "ERROR: MSBuild failed, code:" 
> $LASTEXITCODE
> +             Exit $LASTEXITCODE
> +     }
>  }
> 
>  Function Run-MSBuildSDV {
> --
> 2.16.2.windows.1
> 
> 
> _______________________________________________
> win-pv-devel mailing list
> win-pv-devel@xxxxxxxxxxxxxxxxxxxx
> https://lists.xenproject.org/mailman/listinfo/win-pv-devel


_______________________________________________
win-pv-devel mailing list
win-pv-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/win-pv-devel