[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [win-pv-devel] [PATCH xeniface] Get rid of bogus time adjustment


  • To: Paul Durrant <Paul.Durrant@xxxxxxxxxx>, "win-pv-devel@xxxxxxxxxxxxxxxxxxxx" <win-pv-devel@xxxxxxxxxxxxxxxxxxxx>
  • From: Owen Smith <owen.smith@xxxxxxxxxx>
  • Date: Mon, 16 Sep 2019 14:39:07 +0000
  • Accept-language: en-GB, en-US
  • Authentication-results: esa6.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none; spf=None smtp.pra=owen.smith@xxxxxxxxxx; spf=Pass smtp.mailfrom=owen.smith@xxxxxxxxxx; spf=None smtp.helo=postmaster@xxxxxxxxxxxxxxx
  • Cc: Paul Durrant <Paul.Durrant@xxxxxxxxxx>
  • Delivery-date: Mon, 16 Sep 2019 14:39:14 +0000
  • Ironport-sdr: RrpPWH0XZs0msBa1H+I/ejSnDS2Bc1fBiSL/Vv9TEu3HxVE4psynOLe+RWwKQUqaQWocL3WHB4 JzKPFQfuPzFrbuNUXcYEDFAGRISm8lvUWevDGbaGEFdpy4xPcCEFNwhYLWRS7q8MMNsVMZXZ5U SXUd/bPLRAlGo7e1OLu9+WuK8d2f7bJGMRgvhUGm4t0xal4YWsou81Bb4FQ6FNRryL9RAq1W83 73DkqDgnz63HKlr4p1jN9G1W3o5514AY6ygwB4I59Lxb8oZB2oACs/ViuvhkQl8LWz4boJiQ5h PyE=
  • List-id: Developer list for the Windows PV Drivers subproject <win-pv-devel.lists.xenproject.org>
  • Thread-index: AQHVbJJyR/WPFh37oEehbpkmrkRzracuX2rQ
  • Thread-topic: [win-pv-devel] [PATCH xeniface] Get rid of bogus time adjustment


> -----Original Message-----
> From: win-pv-devel [mailto:win-pv-devel-bounces@xxxxxxxxxxxxxxxxxxxx] On
> Behalf Of Paul Durrant
> Sent: 16 September 2019 14:27
> To: win-pv-devel@xxxxxxxxxxxxxxxxxxxx
> Cc: Paul Durrant <Paul.Durrant@xxxxxxxxxx>
> Subject: [win-pv-devel] [PATCH xeniface] Get rid of bogus time adjustment
> 
> Xen maintains synchronization between the wallclock (as reported in the
> shared info) and the emulated RTC. Thus all the guest agent needs to know,
> to correctly interpret the wallclock, is whether Windows is setting the RTC in
> local time or UTC. No adjustment of the wallclock is required.
> 
> Signed-off-by: Paul Durrant <paul.durrant@xxxxxxxxxx>
> ---
>  src/xenagent/service.cpp | 25 -------------------------
>  1 file changed, 25 deletions(-)
> 
> diff --git a/src/xenagent/service.cpp b/src/xenagent/service.cpp index
> a77ff23..8f8f445 100644
> --- a/src/xenagent/service.cpp
> +++ b/src/xenagent/service.cpp
> @@ -404,28 +404,6 @@ bool CXenIfaceCreator::IsRTCInUTC()
>      return val;
>  }
> 
> -void CXenIfaceCreator::AdjustXenTimeToUTC(FILETIME* now) -{

AdjustXenTimeToUTC will also need the method taking out of service.h

> -    std::string vm;
> -    if (!m_device->StoreRead("vm", vm))
> -        return;
> -
> -    std::string offs;
> -    if (!m_device->StoreRead(vm + "/rtc/timeoffset", offs))
> -        return;
> -
> -    long offset = (long)atoi(offs.c_str());
> -
> -    ULARGE_INTEGER lnow;
> -    lnow.LowPart  = now->dwLowDateTime;
> -    lnow.HighPart = now->dwHighDateTime;
> -
> -    lnow.QuadPart -= ((LONGLONG)offset * 1000000);
> -
> -    now->dwLowDateTime  = lnow.LowPart;
> -    now->dwHighDateTime = lnow.HighPart;
> -}
> -
>  void CXenIfaceCreator::SetXenTime()
>  {
>      bool IsUTC = IsRTCInUTC();
> @@ -440,9 +418,6 @@ void CXenIfaceCreator::SetXenTime()
>      if (!m_device->SharedInfoGetTime(&now))
>          return;
> 
> -    if (IsUTC)
> -        AdjustXenTimeToUTC(&now);
> -
>      SYSTEMTIME sys = { 0 };
>      if (!FileTimeToSystemTime(&now, &sys))
>          return;
> --
> 2.5.3
> 
> 
> _______________________________________________
> win-pv-devel mailing list
> win-pv-devel@xxxxxxxxxxxxxxxxxxxx
> https://lists.xenproject.org/mailman/listinfo/win-pv-devel
_______________________________________________
win-pv-devel mailing list
win-pv-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/win-pv-devel

 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.