Re: [win-pv-devel] [PATCH] Added ewdk 16 support with vs2017

[Paul Durrant <Paul.Durrant@xxxxxxxxxx>]

> -----Original Message-----
> From: win-pv-devel <win-pv-devel-bounces@xxxxxxxxxxxxxxxxxxxx> On Behalf Of 
> Daniel Davis
> Sent: 09 July 2019 08:34
> To: win-pv-devel@xxxxxxxxxxxxxxxxxxxx
> Cc: Daniel Davis <daniel.davis@xxxxxxxxxx>
> Subject: [win-pv-devel] [PATCH] Added ewdk 16 support with vs2017
>

Hi,

  This patch has no S-o-b so I cannot apply it as-is. Also I need an indication 
of which repo this applies to, since I cannot guess from the patch content. Can 
you please make sure that the subject line specifies that?
 
> ---
>  build.ps1 | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/build.ps1 b/build.ps1
> index f154aee..552e9d7 100644
> --- a/build.ps1
> +++ b/build.ps1
> @@ -19,8 +19,8 @@ Function Build {
>       )
> 
>       $visualstudioversion = $Env:VisualStudioVersion
> -     $solutiondir = @{ "14.0" = "vs2015"; "15.0" = "vs2017"; }
> -     $configurationbase = @{ "14.0" = "Windows 8"; "15.0" = "Windows 8"; }
> +     $solutiondir = @{ "14.0" = "vs2015"; "15.0" = "vs2017";"16.0" = 
> "vs2017"; }
> +     $configurationbase = @{ "14.0" = "Windows 8";"15.0" = "Windows 8"; 
> "16.0" = "Windows 8"; }
> 
>       $params = @{
>               SolutionDir = $solutiondir[$visualstudioversion];
> @@ -33,8 +33,8 @@ Function Build {
> 
>  Function SdvBuild {
>       $visualstudioversion = $Env:VisualStudioVersion
> -     $solutiondir = @{ "14.0" = "vs2015"; "15.0" = "vs2017"; }
> -     $configurationbase = @{ "14.0" = "Windows 10"; "15.0" = "Windows 10"; }
> +     $solutiondir = @{ "14.0" = "vs2015"; "15.0" = "vs2017"; "16.0" = 
> "vs2017"; }
> +     $configurationbase = @{ "14.0" = "Windows 10";"15.0" = "Windows 10"; 
> "16.0" = "Windows 10"; }
>       $arch = "x64"

  Please make sure that the ';' are consistently followed by ' '.

  Thanks,

    Paul

> 
>       $params = @{
> --
> 2.22.0.windows.1
> 
> 
> _______________________________________________
> win-pv-devel mailing list
> win-pv-devel@xxxxxxxxxxxxxxxxxxxx
> https://lists.xenproject.org/mailman/listinfo/win-pv-devel
_______________________________________________
win-pv-devel mailing list
win-pv-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/win-pv-devel