Re: [win-pv-devel] [PATCH] Dont log CacheCreateSlab failures due to the cap

[Paul Durrant <Paul.Durrant@xxxxxxxxxx>]

> -----Original Message-----
> From: win-pv-devel <win-pv-devel-bounces@xxxxxxxxxxxxxxxxxxxx> On Behalf Of 
> Owen Smith
> Sent: 08 July 2019 09:38
> To: win-pv-devel@xxxxxxxxxxxxxxxxxxxx
> Cc: Owen Smith <owen.smith@xxxxxxxxxx>
> Subject: [win-pv-devel] [PATCH] Dont log CacheCreateSlab failures due to the 
> cap
> 
> Signed-off-by: Owen Smith <owen.smith@xxxxxxxxxx>
> ---
>  src/xenbus/cache.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/src/xenbus/cache.c b/src/xenbus/cache.c
> index 7daf8da..4687241 100644
> --- a/src/xenbus/cache.c
> +++ b/src/xenbus/cache.c
> @@ -313,11 +313,9 @@ fail3:
>      MmFreeContiguousMemory(Slab);
> 
>  fail2:
> -    Error("fail2\n");
> +    Error("fail2 (%08x)\n", status);
> 
>  fail1:
> -    Error("fail1 (%08x)\n", status);
> -

Actually I'd prefer to log squash on the basis of the status, which is 
STATUS_INSUFFICIENT_RESOURCES in the case of hitting the cap vs. 
STATUS_NO_MEMORY in the case of an actual out-of-memory condition.

  Paul

>      return NULL;
>  }
> 
> --
> 2.16.2.windows.1
> 
> 
> _______________________________________________
> win-pv-devel mailing list
> win-pv-devel@xxxxxxxxxxxxxxxxxxxx
> https://lists.xenproject.org/mailman/listinfo/win-pv-develSTATUS_NO_MEMORY
_______________________________________________
win-pv-devel mailing list
win-pv-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/win-pv-devel